test(benchmarks): Add warmup for native daemon startup - #2154
Merged
Merged
Conversation
PR #1955 cut Linux startup time by ~60% by signaling native daemon readiness before loading `libcurl` and initializing the transport. Imported from the native IPC work for #1834, where breadcrumbs, contexts, and tags send updates to the daemon. The daemon starts reading only after transport initialization, so a full IPC buffer can block sends and add startup delay to benchmark timings. Wait for the `Entering main loop` log before timing these benchmarks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2154 +/- ##
=======================================
Coverage 75.43% 75.44%
=======================================
Files 103 103
Lines 28078 28078
Branches 5127 5127
=======================================
+ Hits 21182 21184 +2
+ Misses 5564 5559 -5
- Partials 1332 1335 +3 🚀 New features to boost your workflow:
|
limbonaut
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1955 cut Linux startup time by ~60% by signaling native daemon readiness before loading
libcurland initializing the transport, and we definitely want to keep that improvement. When running benchmarks, though, we need to make sure the entire pipeline is fully up and running.This becomes especially important when scope updates are sent over IPC to the daemon. The daemon starts reading only after transport startup, so a full IPC buffer can block sends and add misleading delay to benchmark timings. Wait for the
Entering main looplog before timing these benchmarks to avoid transport startup time indirectly leaking into benchmarks and twisting the results.