Skip to content

feat(boto3): Add S3 service extension - #7617

Draft
pabloDeputter wants to merge 4 commits into
pablo/add-boto3-service-extension-classfrom
pablo/add-boto3-s3-service
Draft

pabloDeputter wants to merge 4 commits into
pablo/add-boto3-service-extension-classfrom
pablo/add-boto3-s3-service

Conversation

@pabloDeputter

Copy link
Copy Markdown
Member

Description

  • add the following service-specific attributes:
    • aws.s3.bucket required in almost all s3 operations except list-buckets.
    • http.response.body.size which is the number of bytes in the payload.
  • add the following OTel attributes that are NOT yet in sentry-conventions:
    • aws.s3.copy_source
    • aws.s3.delete
    • aws.s3.key
    • aws.s3.part_number
    • aws.s3.upload_id
    • aws.s3.object_size (not in OTel) which is the total size of the s3 object itself.
      • extracted from ContentLength on GetObject and HeadObject responses; ObjectSize on GetObjectAttributes, and ContentLength on PutObject requests. For ranged GetObject or HeadObject calls, ContentLength is the used size.
  • more information where these parameters can be found/extracted from in https://opentelemetry.io/docs/specs/semconv/object-stores/s3/ & https://opentelemetry.io/docs/specs/semconv/registry/attributes/aws/#amazon-s3-attributes

Issues

Resolves #7576

@pabloDeputter
pabloDeputter changed the base branch from master to pablo/add-boto3-service-extension-class September 22, 2026 14:50
@pabloDeputter
pabloDeputter added this pull request to stack #7541 September 22, 2026 14:52
@pabloDeputter
pabloDeputter force-pushed the pablo/add-boto3-s3-service branch from ca45d46 to 0c2873f Compare September 22, 2026 14:53
@pabloDeputter
pabloDeputter removed this pull request from stack #7541 September 22, 2026 14:57
@pabloDeputter
pabloDeputter added this pull request to stack #7618 September 22, 2026 14:57
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

130540 passed | ⏭️ 7171 skipped | Total: 137711 | Pass Rate: 94.79% | Execution Time: 434m 7s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +1232
Passed Tests 📈 +1210
Failed Tests 📉 -1
Skipped Tests 📈 +23

➖ Removed Tests (1)

View removed tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module

All tests are passing successfully.

✅ Patch coverage is 82.89%. Project has 2565 uncovered lines.
✅ Project coverage is 90.28%. Comparing base (d7727cd) to head (0c2873f).

Files with missing lines (2)
File Patch % Lines
sentry_sdk/integrations/boto3/_services/s3.py 72.09% ⚠️ 12 Missing and 5 partials
sentry_sdk/integrations/boto3/_services/_attribute_extraction.py 93.75% ⚠️ 1 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.21%    90.28%    +0.07%
==========================================
  Files          194       203        +9
  Lines        25997     26400      +403
  Branches      9662      9780      +118
==========================================
+ Hits         23454     23835      +381
- Misses        2543      2565       +22
- Partials      1451      1468       +17

Generated by Codecov Action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(boto3): Add S3 service extension

1 participant