Skip to content

ref(arq): Drop support for send_default_pii - #7627

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/remove-pii-arq
Sep 23, 2026
Merged

sentrivana merged 3 commits into
major/3.0from
ivana/major/remove-pii-arq

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 23, 2026

Copy link
Copy Markdown

PY-2808

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

66856 passed | ❌ 1 failed | ⏭️ 3019 skipped | Total: 69876 | Pass Rate: 95.68% | Execution Time: 188m 22s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -67025
Passed Tests 📉 -62897
Failed Tests 📈 +1
Skipped Tests 📉 -4129

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139838981341184

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139838981341184

✅ Patch coverage is 100.00%. Project has 2093 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (e7f379e) to head (ddedd8e).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.10%    -0.12%
==========================================
  Files          194       180       -14
  Lines        25997     21145     -4852
  Branches      9662      7652     -2010
==========================================
+ Hits         23454     19052     -4402
- Misses        2543      2093      -450
- Partials      1451      1200      -251

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review September 23, 2026 09:05
@sentrivana
sentrivana requested a review from a team as a code owner September 23, 2026 09:05
@sentrivana
sentrivana merged commit 719a46b into major/3.0 Sep 23, 2026
145 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-pii-arq branch September 23, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants