Skip to content

ref(aiohttp): Remove support for send_default_pii - #7632

Merged
sentrivana merged 7 commits into
major/3.0from
ivana/drop-pii-aiohttp
Sep 23, 2026
Merged

sentrivana merged 7 commits into
major/3.0from
ivana/drop-pii-aiohttp

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 23, 2026

Copy link
Copy Markdown

PY-2809

@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

66270 passed | ❌ 1 failed | ⏭️ 3019 skipped | Total: 69290 | Pass Rate: 95.64% | Execution Time: 192m 36s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -67611
Passed Tests 📉 -63483
Failed Tests 📈 +1
Skipped Tests 📉 -4129

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140002865106944

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140002865106944

✅ Patch coverage is 90.32%. Project has 2090 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (27e0e78) to head (697e3fe).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/aiohttp.py 90.32% ⚠️ 3 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.10%    -0.12%
==========================================
  Files          194       180       -14
  Lines        25997     21106     -4891
  Branches      9662      7624     -2038
==========================================
+ Hits         23454     19016     -4438
- Misses        2543      2090      -453
- Partials      1451      1198      -253

Generated by Codecov Action

@sentrivana sentrivana changed the title ref(aiohttp): Remove support for send_default_pii ref(aiohttp): Remove support for send_default_pii Sep 23, 2026
@sentrivana
sentrivana marked this pull request as ready for review September 23, 2026 11:35
@sentrivana
sentrivana requested a review from a team as a code owner September 23, 2026 11:35

@pytest.mark.asyncio
@pytest.mark.parametrize("send_pii", [True, False])
async def test_url_query_attribute(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extensive data_collection version of this test

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 627b51d. Configure here.

Comment thread tests/integrations/aiohttp/test_aiohttp.py
@sentrivana
sentrivana merged commit e118c9c into major/3.0 Sep 23, 2026
145 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/drop-pii-aiohttp branch September 23, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants