Do not backfill unset send_default_pii - #7633
Closed
sentrivana wants to merge 1 commit into
Closed
sentrivana wants to merge 1 commit into
sentrivana wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
send_default_piiis unset, fall back to defaultdata_collectioninstead of backfilling adata_collectionconfig based onsend_default_pii=False.This means any test that currently doesn't set neither
send_default_piinordata_collectionwill test the behavior of the SDK where the defaultdata_collectionapplies. Previously, it'd be testing SDK behavior wheresend_default_pii=False, which is not the same.