Repository navigation
Conversation
The test read the response right away and relied on the copy outrunning it. On a slow runner the client kept up, got the whole artifact and the test failed (seen on Windows). It now reads only after the upstream body is closed, so the client is always behind.
Merged
Contributor
|
Thanks for fixing this. Closing as a duplicate of 28ce5f4, which is already on main and fixes the same test race by waiting for the background fetch to finish before reading the response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCacheMissSlowClientFailsWithoutStoredCopy(from #609) read the response right away and relied on the upstream copy outrunning the client. On a slow runner the client kept up, got the whole artifact, and the test failed: "read 409563 bytes without error" on Windows in #608 and #610.The test now starts reading only after the proxy has closed the upstream body, so the client is always more than the feed limit behind. Reproduced the failure locally with a throttled upstream body; the new version doesn't depend on timing.