Conversation
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Copilot review overview
🟡 Changes recommended
Restoring inputs now fails when no persisted state exists, breaking the previous no-op behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds contextual error messages to JSON parsing failures across action inputs, CLI output, tracer configuration, and SARIF handling.
Changes:
- Wraps several
JSON.parsecalls with contextual errors. - Includes relevant paths, inputs, or language details in failures.
- Updates the generated JavaScript bundle.
| File | Description |
|---|---|
src/util.ts |
Adds context to matrix parsing and object cloning errors. |
src/tracer-config.ts |
Identifies the tracing configuration file on failure. |
src/sarif/index.ts |
Identifies the SARIF file on parsing failure. |
src/codeql.ts |
Adds language and CLI output to extractor parsing errors. |
src/actions-util.ts |
Adds context when restoring persisted inputs. |
lib/entry-points.js |
Generated bundle; excluded from review by policy. |
Files excluded by content exclusion policy (1)
- lib/entry-points.js
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR wraps a few existing
JSON.parsecalls intry/catchblocks in order to (essentially) re-throw errors with more context added to them about the specificJSON.parsecall that failed. That can help with troubleshooting in cases where the context of the failure isn't otherwise apparent from a downstream error handler. This doesn't change any behaviour.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.upload-sarifaction.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist