Skip to content

Improve security and licensing - #1

Merged
githubflyideas merged 2 commits into
mainfrom
fix/review-hardening-loopback-web
Nov 9, 2026
Merged

githubflyideas merged 2 commits into
mainfrom
fix/review-hardening-loopback-web

Conversation

@githubflyideas

Copy link
Copy Markdown
Owner

Improve security defaults and clarify licensing.

  • Default the Web UI to localhost and add security headers.
  • Fix stale links, build instructions, and release packaging.
  • Use Apache-2.0, reserve trademark rights, and preserve notices.
  • Keep existing data paths compatible.

Tests: Local Go, Node, browser, and package checks passed. TUI, systemd, and VyOS VM checks were not run locally.

- serve: Web UI defaults to 127.0.0.1:8066; interactive Enter means
  loopback, 0.0.0.0/:: must be typed explicitly; flags/env unchanged.
  sFlow default 0.0.0.0:6343 kept for remote exporters. Startup log
  explains remote access for loopback-only Web.
- api: CSP (same-origin scripts, no framing), X-Frame-Options,
  nosniff, Referrer-Policy and COOP on every response; logo keeps its
  stricter sandbox policy. Tests check headers and that the embedded
  page has no inline scripts/handlers.
- Go module path and install links use githubflyideas/vyos-sflow;
  help links and certificate download name no longer say traffic66.
- CI: release tar stores owner/group 0 and verifies it.
- Docs: compatibility note for the new Web default; versioned dev
  build command; README states that LICENSE (Apache-2.0) and inherited
  LICENSE.md (PolyForm NC) + ADDITIONAL-USE-GRANT.md coexist and the
  copyright holder has not clarified which applies. License texts are
  unchanged. Legacy vyso_sflow_data / traffic66.duckdb names retained
  for data compatibility.
- CHANGELOG: Unreleased section (no version bump, no release).
Remove the inherited PolyForm Noncommercial LICENSE.md and
ADDITIONAL-USE-GRANT.md; keep the Apache-2.0 LICENSE text unchanged.
Add NOTICE (copyright, Traffic66 attribution) and TRADEMARKS.md (names
and logo reserved per Apache-2.0 section 6) and ship both in release
archives. Keep upstream-manifest.json unchanged as historical
provenance. Release-contract test checks license/package consistency.
@githubflyideas
githubflyideas merged commit 2d68cd6 into main Nov 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant