esbuildsandbox, the leak the engine found - #17
Merged
Merged
Conversation
Three modules, two in the table. The missing one is the security fix: bundling a page's own script graph through esbuild looks sandboxed because every import in your tests goes through your plugin, and a glob dynamic import does not — the bundler walks ResolveDir on the real filesystem, following symlinks, with the plugin API never seeing it. A module that exists because somebody hit that is the one worth finding before hitting it, and it was on no page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three modules, two in the table. The missing one is the security fix.
Bundling a page's own
<script type="module">graph through esbuild looks sandboxed: every import in your own tests goes through yourOnResolve/OnLoadplugin. A glob dynamic import does not — the bundler expands it by walkingResolveDiron the real filesystem through its internal resolver, following symlinks, with the plugin API never seeing it."/"is a common default for that field.A module that exists because somebody hit that is exactly the one worth finding before hitting it, and it was on no page of the organisation that found it.
🤖 Generated with Claude Code