js: implement HTMLMediaElement.currentTime/play/pause/paused - #240
Merged
Merged
Conversation
This engine has no <video>/<audio> support at all -- no entry anywhere in isReplacedTag or any binder file. Implemented the storage-only subset a script needs to stay internally consistent (currentTime read/write, play()/pause() toggling paused, the same "storage without real playback effect" shape as scrollTop/scrollLeft) -- no real media decoding/playback, since a static renderer has no timeline to advance. Found sweeping a third, freshly-fetched corpus page (archive.org's own item-detail viewer) after both prior corpora were exhausted. Most of the initial grep hits (duration, volume, muted, paused) turned out to be jQuery/Bootstrap internals unrelated to media elements -- traced each one back to its actual surrounding code before trusting it. The one confirmed real trigger: clicking a transcript entry finds the real <video> element and does videoEl.currentTime = ...; videoEl.play() to seek and resume playback. play() returns a real Promise, matching the spec's own return type. duration/volume/muted/readyState/playbackRate deliberately left out: no confirmed real trigger for any of them survived closer inspection. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<video>/<audio>support at all — no entry anywhere inisReplacedTagor any binder file.currentTime(read/write),play()/pause()(methods togglingpaused), the same "storage without real playback effect" shape asscrollTop/scrollLeft— no real media decoding/playback, since a static renderer has no timeline to advance.duration,volume,muted,.paused) turned out to be jQuery's own$.fx.speedsanimation internals and Bootstrap's carousel widget — unrelated to media elements at all. Traced each hit back to its actual surrounding code before trusting it. The one confirmed real trigger: clicking a transcript entry finds the real<video>element (shadowRoot.querySelector("video")) and doesvideoEl.currentTime = ...; videoEl.play()to seek and resume playback.play()returns a realPromise, matching the spec's own return type.duration/volume/muted/readyState/playbackRatedeliberately left out — no confirmed real trigger for any of them survived closer inspection.Test plan
TestMediaElementCurrentTimeAndPlayPause, git-stash-confirmed: reverting turnscurrentTime/pausedintoundefinedand makes.play()throwTypeError: Object has no member 'play'.go build ./... && go vet ./... && go test ./...clean.🤖 Generated with Claude Code