Repository navigation
[bot] Merge master/7c0e9960 into rel/dev - #1932
Merged
Merged
Conversation
Custom application settings had no gooddata-sdk methods, so reading or writing them meant calling gooddata-api-client directly. The list call also needed _check_return_type=False, because the generated client fails to validate *OutWithLinks list items (PSDK-233). Add CatalogCustomApplicationSetting and list, get, create_or_update and delete methods on catalog_workspace, following the workspace-settings methods. The list and get calls handle the generated-client validation issue inside the SDK. create_or_update returns an UpsertOutcome. A setting without an id can be created, and the server generates the id. The generated PostOptionalId model rejects id=None, so to_api omits the key. The workspace-settings create path still fails without an id and is left as is. PATCH is not wrapped, because create_or_update covers updates. Cassettes were recorded against the local docker-compose stack. Cleanup for the id-less test finds the setting by application name, so a failure after create cannot leak it into later runs. Docs gain pages for these methods and for the existing, undocumented workspace-settings methods. jira: PSDK-242 risk: low
The id-less create of a custom application setting neither returns the generated id nor sets it on the object, so a repeated call creates another setting. Point callers to an explicit id or to list_custom_application_settings. Workspace settings still need an explicit id, because creation with the default None fails. jira: PSDK-242 risk: nonprod
…settings feat(gooddata-sdk): add workspace custom application settings methods
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1932 +/- ##
===========================================
+ Coverage 86.17% 86.18% +0.01%
===========================================
Files 344 345 +1
Lines 25901 25954 +53
===========================================
+ Hits 22319 22368 +49
- Misses 3582 3586 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 7c0e996 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/42619873410).