Repository navigation
[bot] Merge master/5f40cd0d into rel/dev - #1944
Merged
Merged
Conversation
best_run_latency_s was only ever populated on the single-shot path; every agentic kind (agentic_*, vis_agentic) always reported it as null. Adds per-run wall-clock timing to all agentic evaluators and wires the rank-selected run's latency into ItemReport. Three findings from review (dropped conditional checks in alert_skill's best-run detail, over-broad except Exception in anomaly_detection/what_if) are tracked separately: #1942 jira: trivial risk: low Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
First of three evaluators for product skills with no eval coverage so far: forecasting, what-if analysis, anomaly detection. This one checks forecasting correctness, not just completion -- the skill refuses to execute unless the visualization carries an AAC forecast config, so the requested horizon, metric, confidence and seasonality are all numbers in the tool call itself, checkable with no judge. A review finding (forecasting turns not joined to the item's Langfuse trace scope under clarification) is tracked separately: #1941 jira: trivial risk: low Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1944 +/- ##
===========================================
+ Coverage 86.32% 86.44% +0.11%
===========================================
Files 346 348 +2
Lines 26408 26670 +262
===========================================
+ Hits 22797 23054 +257
- Misses 3611 3616 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 5f40cd0 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/43021112302).