Skip to content

Fix iOS test compilation by removing illegal characters from test names - #4001

Merged
rfontanarosa merged 2 commits into
masterfrom
rfontanarosa/fix-ios-test-names
Nov 6, 2026
Merged

rfontanarosa merged 2 commits into
masterfrom
rfontanarosa/fix-ios-test-names

Conversation

@rfontanarosa

Copy link
Copy Markdown
Collaborator

No description provided.

@rfontanarosa

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies and standardizes the backtick-enclosed test method names across multiple Kotlin test files by removing parentheses, commas, and hash symbols. No review comments were provided, so there is no additional feedback to address.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the test method names across multiple unit test files (including MogImageMetadataTest, MogSourceTest, MogTileTest, PixelCoordinatesTest, and various UseCase tests) by removing parentheses and commas from the backtick-enclosed test names. This improves readability and consistency in test reporting. There are no review comments to address, and I have no additional feedback to provide.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.03%. Comparing base (bb45618) to head (60416e5).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4001   +/-   ##
=========================================
  Coverage     70.03%   70.03%           
  Complexity     2106     2106           
=========================================
  Files           441      441           
  Lines         11869    11869           
  Branches       1545     1545           
=========================================
  Hits           8313     8313           
  Misses         2780     2780           
  Partials        776      776           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfontanarosa
rfontanarosa merged commit 44237d4 into master Nov 6, 2026
18 checks passed
@rfontanarosa
rfontanarosa deleted the rfontanarosa/fix-ios-test-names branch November 6, 2026 17:37

This branch was successfully deployed

1 active deployment
e2e-approval — 60416e5c Deployed Nov 6, 2026 by rfontanarosa via instrumentation-tests / request-approval #1378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant