Repository navigation
core: reduce MAX_PARSER_DEPTH to prevent stack overflow on deep nesting - #1339
Open
jdymitarai wants to merge 1 commit into
Open
jdymitarai wants to merge 1 commit into
jdymitarai wants to merge 1 commit into
Conversation
When parsing deeply nested structures (e.g. conditional branches, assert chains, or deep arrays), recursive descent parser calls consume stack frame space that can exhaust the thread stack under AddressSanitizer or default stack sizes before reaching MAX_PARSER_DEPTH = 1000. Lower MAX_PARSER_DEPTH to 500 to reliably trigger a controlled static error before stack memory exhaustion, preventing ASAN stack-overflow / SIGSEGV. Fixes google#1117
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
When parsing deeply nested constructs (such as deep conditional expressions, assert chains, or deeply nested arrays), recursive descent parser calls consume stack space across Parser::parse, maybeParseGreedy, and parseTerminalBracketsOrUnary. Under AddressSanitizer or default thread stack allocations, stack exhaustion occurs before reaching MAX_PARSER_DEPTH = 1000, causing an unhandled stack-overflow crash (SIGSEGV).
Fix Approach
Reduce MAX_PARSER_DEPTH from 1000 to 500. This ensures that pathological or deeply nested expressions exceed the parse depth limit and abort cleanly via StaticError before the host execution stack is exhausted.
Verification
Fixes #1117