Repository navigation
core: enforce recursion depth limits when parsing function parameters and arguments - #1340
Open
jdymitarai wants to merge 1 commit into
Open
jdymitarai wants to merge 1 commit into
jdymitarai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
While recursion depth tracking was introduced in Parser functions, parseParams did not check current_depth >= MAX_PARSER_DEPTH before processing arguments, and call sites in parseBind, parseObjectRemainder, maybeParseGreedy, and parseInfix passed current_depth without incrementing it. This permitted deeply nested function parameter lists and call arguments to consume unbounded stack frames, resulting in stack overflow crashes (SIGSEGV).
Fix Approach
Add a recursion depth guard in Parser::parseParams and increment current_depth when dispatching parseParams and parseArgs across binding and infix expression parsing.
Verification
Fixes #1116