Repository navigation
Add unit tests for uncovered android_device and logcat_processor paths - #1067
Merged
Merged
Conversation
xpconanfan
changed the title
- list_adb_devices_by_usb_id: real parsing of 'adb devices -l' output (previously only ever mocked). - LogcatListenerContext._listen_loop: stops mid-batch when the stop event is set during dispatch. - LogcatProcessor.wait_for(in_order=False, since=<timestamp-only position>): skips lines before the since timestamp and times out when only stale lines match.
xpconanfan
force-pushed
the
coverage_gaps
branch
from
October 9, 2026 21:39
56b3e25 to
be44b83
Compare
xianyuanjia
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_adb_devices_by_usb_id: real parsing ofadb devices -loutput (previously only ever mocked).LogcatListenerContext._listen_loop: stops mid-batch when the stop event is set during dispatch.LogcatProcessor.wait_for(in_order=False, since=<timestamp-only position>): skips lines before thesincetimestamp and times out when only stale lines match.