Skip to content

Use Guava BaseEncoding for RDAP search cursors - #3275

Merged
CydeWeys merged 1 commit into
google:masterfrom
CydeWeys:rdap-guava-base64
Nov 18, 2026
Merged

CydeWeys merged 1 commit into
google:masterfrom
CydeWeys:rdap-guava-base64

Conversation

@CydeWeys

@CydeWeys CydeWeys commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Replace java.util.Base64 with Guava's pure-Java BaseEncoding.base64() in RdapSearchActionBase when encoding and decoding pagination cursor tokens, providing defense-in-depth against CVE-2026-114938 on public RDAP search endpoints.

Enforce a 512-character pre-decode length bound on untrusted cursor tokens so oversized or malformed cursors fail fast with HTTP 400 Bad Request, and add unit tests covering malformed, oversized, and maximum-length cursors.

BUG= http://b/587369531


This change is Reviewable

Replace java.util.Base64 with Guava's pure-Java BaseEncoding.base64()
in RdapSearchActionBase when encoding and decoding pagination cursor
tokens, providing defense-in-depth against CVE-2026-114938 on public
RDAP search endpoints.

Enforce a 512-character pre-decode length bound on untrusted cursor
tokens so oversized or malformed cursors fail fast with HTTP 400 Bad
Request, and add unit tests covering malformed, oversized, and
maximum-length cursors.

BUG= http://b/587369531

@jicelhay jicelhay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jicelhay reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on CydeWeys).

@CydeWeys
CydeWeys added this pull request to the merge queue Nov 18, 2026
Merged via the queue into google:master with commit 9f17c12 Nov 18, 2026
16 checks passed
@CydeWeys
CydeWeys deleted the rdap-guava-base64 branch November 18, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants