Repository navigation
Conversation
Member
Author
|
Do note that there are reasons to perform a superuser delete (that bypasses some checks and even can delete a domain instantly, bypassing the normal deletion lifecycle). However, this probably doesn't need to be doable through the bulk domain action. |
Fix two bugs in ConsoleBulkDomainAction: - Add runAsSuperuser() to ConsoleDomainActionType (returning true for SUSPEND and UNSUSPEND and false for DELETE) and pass it to EppController instead of user.getUserRoles().isAdmin(). Previously, DomainUpdateFlow rejected the server-only suspension statuses for non-admin FTE and SUPPORT_LEAD users who hold SUSPEND_DOMAIN. Superuser status is now driven solely by the action type, so DELETE never runs as superuser through the bulk domain action, even for admins. Superuser deletes, which bypass server statuses and can delete domains immediately, remain available through the nomulus CLI. - Prefix ConsoleUpdateHistory descriptions with '<registrarId>|' using ConsoleUpdateHistory.DESCRIPTION_SEPARATOR so bulk domain actions are returned by ConsoleHistoryDataAction's registrar history query and parsed properly in the Console history UI. - Add unit tests in ConsoleBulkDomainActionTest covering non-admin FTE and SUPPORT_LEAD suspend/unsuspend flows, permission enforcement, non-superuser DELETE for both admin and non-admin users, and ConsoleHistoryDataAction queries. BUG= http://b/586480958
CydeWeys
force-pushed
the
fix-console-bulk-domain-suspend
branch
from
November 18, 2026 21:55
1c308aa to
e99294b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two bugs in ConsoleBulkDomainAction:
SUSPEND and UNSUSPEND and false for DELETE) and pass it to
EppController instead of user.getUserRoles().isAdmin(). Previously,
DomainUpdateFlow rejected the server-only suspension statuses for
non-admin FTE and SUPPORT_LEAD users who hold SUSPEND_DOMAIN.
Superuser status is now driven solely by the action type, so DELETE
never runs as superuser through the bulk domain action, even for
admins. Superuser deletes, which bypass server statuses and can
delete domains immediately, remain available through the nomulus CLI.
<registrarId>|usingConsoleUpdateHistory.DESCRIPTION_SEPARATOR so bulk domain actions are
returned by ConsoleHistoryDataAction's registrar history query and
parsed properly in the Console history UI.
and SUPPORT_LEAD suspend/unsuspend flows, permission enforcement,
non-superuser DELETE for both admin and non-admin users, and
ConsoleHistoryDataAction queries.
BUG= http://b/586480958
This change is