Skip to content

Harden Gemini skills and tighten GEMINI.md - #3284

Open
CydeWeys wants to merge 1 commit into
google:masterfrom
CydeWeys:harden-skills-and-gemini-md
Open

CydeWeys wants to merge 1 commit into
google:masterfrom
CydeWeys:harden-skills-and-gemini-md

Conversation

@CydeWeys

@CydeWeys CydeWeys commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

pr-polisher:

  • Fix the check_diff.py invocation path in SKILL.md so it runs from the
    repository root, and add a "Don't use for" boundary.
  • Add checklist steps for commit-message / PR-body parity, @action
    reachability (RequestComponent, routing.txt, Cloud Scheduler tasks),
    and paginated retrieval of all PR review comments via gh api.
  • check_diff.py: fail when Flyway scripts are combined with Java or
    db-schema.sql.generated changes (2-PR schema split), remind to run
    :db:test and :core:sqlIntegrationTest when Flyway scripts or JPA
    entities change, fail on internal-only links or paths in added lines
    of this public repository, warn when local upstream/master is more
    than 24h old, and widen missing-test detection to common, db,
    networking, prober, proxy, and release. The origin/master sync
    speedup from Improve pr-polisher formatting and output checks #3243 is preserved.

java-ast-refactoring:

  • run_rewrite.sh no longer fails copying ./rewrite.yml onto itself and
    no longer deletes a user's recipe; it only removes a temporary copy.
  • Replace the incorrect ChangeMethodAccessLevel example under "Change
    Method Arguments" with DeleteMethodArgument and
    ReorderMethodArguments.
  • SKILL.md: add a "Don't use for" boundary, skip the console webapp
    build during compile verification, and add verification and error
    recovery steps.

GEMINI.md:

  • Merge the two concatenated documents into one, deduplicating the
    source control, single-commit, package-lock, push, and PR polisher
    sections (189 -> 120 lines).
  • Remove internal-only dependency update steps, keeping the local
    Gradle lockfile verification sequence.
  • Add Nomulus invariants learned in recent reviews: @GetterDelegate
    with ImmutableSortedSet, model/flows layering, partial-JSON null vs
    [] semantics, tm()/replicaTm() ThreadLocal sharing, JAXB default
    attribute omission, isOneTimeUse(), Console superuser and history
    descriptions, CSVPrinter record separators, JDK_JAVA_OPTIONS parity
    across Kubernetes containers, Node version sync, and test JVM reuse.

BUG= http://b/587437992


This change is Reviewable

pr-polisher:
- Fix the check_diff.py invocation path in SKILL.md so it runs from the
  repository root, and add a "Don't use for" boundary.
- Add checklist steps for commit-message / PR-body parity, @action
  reachability (RequestComponent, routing.txt, Cloud Scheduler tasks),
  and paginated retrieval of all PR review comments via gh api.
- check_diff.py: fail when Flyway scripts are combined with Java or
  db-schema.sql.generated changes (2-PR schema split), remind to run
  :db:test and :core:sqlIntegrationTest when Flyway scripts or JPA
  entities change, fail on internal-only links or paths in added lines
  of this public repository, warn when local upstream/master is more
  than 24h old, and widen missing-test detection to common, db,
  networking, prober, proxy, and release. The origin/master sync
  speedup from google#3243 is preserved.

java-ast-refactoring:
- run_rewrite.sh no longer fails copying ./rewrite.yml onto itself and
  no longer deletes a user's recipe; it only removes a temporary copy.
- Replace the incorrect ChangeMethodAccessLevel example under "Change
  Method Arguments" with DeleteMethodArgument and
  ReorderMethodArguments.
- SKILL.md: add a "Don't use for" boundary, skip the console webapp
  build during compile verification, and add verification and error
  recovery steps.

GEMINI.md:
- Merge the two concatenated documents into one, deduplicating the
  source control, single-commit, package-lock, push, and PR polisher
  sections (189 -> 120 lines).
- Remove internal-only dependency update steps, keeping the local
  Gradle lockfile verification sequence.
- Add Nomulus invariants learned in recent reviews: @GetterDelegate
  with ImmutableSortedSet, model/flows layering, partial-JSON null vs
  [] semantics, tm()/replicaTm() ThreadLocal sharing, JAXB default
  attribute omission, isOneTimeUse(), Console superuser and history
  descriptions, CSVPrinter record separators, JDK_JAVA_OPTIONS parity
  across Kubernetes containers, Node version sync, and test JVM reuse.

BUG= http://b/587437992

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant