Repository navigation
Conversation
pr-polisher: - Fix the check_diff.py invocation path in SKILL.md so it runs from the repository root, and add a "Don't use for" boundary. - Add checklist steps for commit-message / PR-body parity, @action reachability (RequestComponent, routing.txt, Cloud Scheduler tasks), and paginated retrieval of all PR review comments via gh api. - check_diff.py: fail when Flyway scripts are combined with Java or db-schema.sql.generated changes (2-PR schema split), remind to run :db:test and :core:sqlIntegrationTest when Flyway scripts or JPA entities change, fail on internal-only links or paths in added lines of this public repository, warn when local upstream/master is more than 24h old, and widen missing-test detection to common, db, networking, prober, proxy, and release. The origin/master sync speedup from google#3243 is preserved. java-ast-refactoring: - run_rewrite.sh no longer fails copying ./rewrite.yml onto itself and no longer deletes a user's recipe; it only removes a temporary copy. - Replace the incorrect ChangeMethodAccessLevel example under "Change Method Arguments" with DeleteMethodArgument and ReorderMethodArguments. - SKILL.md: add a "Don't use for" boundary, skip the console webapp build during compile verification, and add verification and error recovery steps. GEMINI.md: - Merge the two concatenated documents into one, deduplicating the source control, single-commit, package-lock, push, and PR polisher sections (189 -> 120 lines). - Remove internal-only dependency update steps, keeping the local Gradle lockfile verification sequence. - Add Nomulus invariants learned in recent reviews: @GetterDelegate with ImmutableSortedSet, model/flows layering, partial-JSON null vs [] semantics, tm()/replicaTm() ThreadLocal sharing, JAXB default attribute omission, isOneTimeUse(), Console superuser and history descriptions, CSVPrinter record separators, JDK_JAVA_OPTIONS parity across Kubernetes containers, Node version sync, and test JVM reuse. BUG= http://b/587437992
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-polisher:
repository root, and add a "Don't use for" boundary.
reachability (RequestComponent, routing.txt, Cloud Scheduler tasks),
and paginated retrieval of all PR review comments via gh api.
db-schema.sql.generated changes (2-PR schema split), remind to run
:db:test and :core:sqlIntegrationTest when Flyway scripts or JPA
entities change, fail on internal-only links or paths in added lines
of this public repository, warn when local upstream/master is more
than 24h old, and widen missing-test detection to common, db,
networking, prober, proxy, and release. The origin/master sync
speedup from Improve pr-polisher formatting and output checks #3243 is preserved.
java-ast-refactoring:
no longer deletes a user's recipe; it only removes a temporary copy.
Method Arguments" with DeleteMethodArgument and
ReorderMethodArguments.
build during compile verification, and add verification and error
recovery steps.
GEMINI.md:
source control, single-commit, package-lock, push, and PR polisher
sections (189 -> 120 lines).
Gradle lockfile verification sequence.
with ImmutableSortedSet, model/flows layering, partial-JSON null vs
[] semantics, tm()/replicaTm() ThreadLocal sharing, JAXB default
attribute omission, isOneTimeUse(), Console superuser and history
descriptions, CSVPrinter record separators, JDK_JAVA_OPTIONS parity
across Kubernetes containers, Node version sync, and test JVM reuse.
BUG= http://b/587437992
This change is