Repository navigation
internal/driver: make profile comments easier to discover - #1033
jabrailkhalil wants to merge 8 commits into
Conversation
Signed-off-by: Jabrail Khalil <jabrailkhalil@gmail.com>
|
No screenshots? |
|
@aalexand Added the screenshots below and to the PR description. These are captures from actual Chrome execution of the baseline and this PR, using the same example profile. The comments remain available through the existing popover; the change makes that control easier to discover.
|
|
I added the before/after screenshots above and to the PR description, including the narrow viewport. I also updated this branch from main. On current head |
|
@jabrailkhalil The PR seems too verbose for the goal they are achieving. I appreciate the power of AI and welcome pprof contributions, but to make this good use of time, please review the PRs carefully before submitting them. |
|
Agreed, the tests were too much for this change. I've reduced them to one browser test and removed the markup checks. |
|
Integrated current main The driver package tests and scoped go vet pass. I adapted only the added browser regression to main’s chromedp v0.20.1 typed-selector/Do API: it failed compilation before this adaptation and now compiles. Button focus, Space/Enter, visibility and comment assertions remain unchanged. Fresh validation uses Windows Go 1.26.0, inherited from current main. The full Windows suite is not green: the three PE/DWARF mapping subcases also fail on clean current main in the same environment. The initial run additionally lacked the external diff executable; it is not treated as a source regression. Browser modules retain their x86-64 Linux guards and skip execution on Windows: compilation is not a new Linux/browser/race validation. No existing assertions, timing thresholds, platform guards or dependency versions were weakened. Current-head upstream CI and maintainer review are still needed. Could a maintainer approve the new-head workflow and review the integration? |
|
Validated unchanged head The profile-details browser regression actually executes and passes, including mouse activation and focused Space/Enter behavior. With only that browser test applied to main, it fails at the original link's Space-toggle wait (the existing 90-second deadline), rather than at compilation or Chrome setup. Main passed the same Linux commands. Module manifests, checksums and Could a maintainer authorize the upstream workflow and review the current-head integration? |
|
I integrated Could a maintainer approve the pending workflow runs for this head? |




Make profile information easier to discover through the existing details panel. Use a native button with an information icon and expanded-state semantics; profile comments remain in the panel. Space and Enter activate it only when focused.
Current-main integration
Current head:
6927b33b8552ecd3efb68d5e91c99b838d77ed31; integratedmain1facf8f91b50fbab03aa6cb249e0397d91449f9fby a normal, conflict-free merge. All PR implementation/test files are byte-identical to the previous published head. The net PR remains limited to 5 file(s).Validation
Fresh Linux/amd64, Go 1.26.7 and Chrome 156 validation passes the complete unmodified
bash test.sh: both modules, browser tests, race/coverage, vet, formatting, CI-pinned staticcheck commit452d5bb86b45and golangci-lint v2.14.0. Separate uncached race-test JSON passes 537 root tests/subtests (4 existing platform skips) and 4 browser tests/subtests, with no browser skips.The added profile-information keyboard case executed in Chrome. This is fresh Linux evidence; macOS and Windows were not rerun.
These local checks are separate from current-head upstream CI authorization and maintainer review.