Conversation
| @@ -26,6 +26,6 @@ Gem::Specification.new do |gem| | |||
| gem.add_runtime_dependency 'googleauth', '~> 1.14' | |||
| gem.add_runtime_dependency 'mini_mime', '~> 1.1' | |||
| gem.add_runtime_dependency 'multi_json', '~> 1.11' | |||
There was a problem hiding this comment.
bump multi_json to '~> 1.21'
torreypayne
left a comment
There was a problem hiding this comment.
@larouxn LGTM to bump the dependencies for maintenance, but are you sure this update actually clears the warnings? Can you repro?
Thanks for the review! Good call. Unfortunately I believe that due to this (temporary I hope) compatibility fix some deprecation warnings will still appear. I suppose until Reproduction Test (disclaimer: LLM assisted) Running this script with # test_repro.rb
require "multi_json" # 1.21.1
require "representable/json"
class Model
attr_accessor :name
def initialize(name = nil); @name = name; end
end
module ModelRepresenter
include Representable::JSON
property :name
end
m = Model.new("Alice")
m.extend(ModelRepresenter).to_json
Model.new.extend(ModelRepresenter).from_json('{"name":"Bob"}')Result with The MultiJson constant is deprecated and will be removed in v2.0. Use MultiJSON instead.
MultiJSON.dump is deprecated and will be removed in v2.0. Use MultiJSON.generate instead.
MultiJSON.load is deprecated and will be removed in v2.0. Use MultiJSON.parse instead.Result with The MultiJson constant is deprecated and will be removed in v2.0. Use MultiJSON instead.
MultiJSON.dump is deprecated and will be removed in v2.0. Use MultiJSON.generate instead.
MultiJSON.load is deprecated and will be removed in v2.0. Use MultiJSON.parse instead.Note: If we remove |
8bd2ca8 to
c2730d8
Compare
|
Rebased on latest |
To ensure we don't encounter
representablegem basedMultiJsondeprecation warnings I am proposing we raise therepresentablegem version requirement from~> 3.0to~> 3.3andmulti_jsongem version requirement from~> 1.11to~> 1.21.Relevant links