fix: honor max for singular items in PagedResults#each - #28073
Open
torreypayne wants to merge 2 commits into
Open
torreypayne wants to merge 2 commits into
torreypayne wants to merge 2 commits into
Conversation
quartzmo
self-requested a review
October 1, 2026 22:27
quartzmo
reviewed
Oct 1, 2026
| expect(service.fetch_all(max: 5) { |token| responses[token] } ).to contain_exactly('a', 'b', 'c', 'd', 'e') | ||
| end | ||
|
|
||
| it 'should allow limiting the number of singular items to fetch' do |
Member
There was a problem hiding this comment.
Would a quick unit test for max: 0 be worth having here?
A zero max request is fringe for sure, but fetch_all(max: 0, items: :singular) appears to have yielded one item before this change and now yields none after it.
quartzmo
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PagedResults#eachincrementsitem_countand checksmaxin the Array and Hash branches, but the singular-item branch only yields. A sequence of singular pages therefore ignoresmaxand yields every item; it also keeps fetching pages past the limit.This applies the same counting and limit check to the singular branch, and adds specs for both the yielded items and the pages fetched (
max: 2over three singular pages now yields two items and fetches two pages).Fixes #27759. Thanks to @OskarEichler for the report and analysis.