[SamJamCul]

What problem does this pull request solve?

Trello card: https://trello.com/c/wmQXsibH/3337-tell-form-creators-about-archiving-or-making-changes-to-forms-with-save-and-return-enabled

These changes affect live forms with save and return enabled. If you try to make changes or archive a form, the content will vary depending on whether the form's live version has save and return turned on.

Archiving a form with save and return enabled

Make changes to a live form with save and return enabled

Things to consider when reviewing

• Ensure that you consider the wider context.
• Does it work when run on your machine?
• Is it clear what the code is doing?
• Do the commit messages explain why the changes were made?
• Are there all the unit tests needed?
• Do the end to end tests need updating before these changes will pass?
• Has all relevant documentation been updated?

[Copilot]

🟡 Changes recommended

A regression test is needed to verify that enabling save and return in a draft does not trigger the saved-progress warning until the draft is published.

1 open issue

• Test save-and-return eligibility against the published form snapshot · New

What changed in this PR

Adds guidance for form creators about how archiving or publishing changes affects people who have saved their progress.

Changes:

• Checks the published form’s save-and-return setting to select the appropriate warning.
• Adds warnings explaining that saved versions can still receive submissions for up to 30 days.
• Adds model and view coverage for the new behavior.

File	Description
spec/​views/​forms/​make_live/​make_your_changes_live.html.erb_spec.rb	Tests publishing warnings for saved progress.
spec/​views/​forms/​archive_form/​archive.html.erb_spec.rb	Tests archive guidance for saved progress.
spec/​models/​form_spec.rb	Tests the live save-and-return predicate.
config/​locales/​en.yml	Adds warning text and fixes a paragraph closing tag.
app/​views/​forms/​make_live/​make_your_changes_live.html.erb	Selects publishing warnings based on the live setting.
app/​views/​forms/​archive_form/​archive.html.erb	Selects archive guidance based on the live setting.
app/​models/​form.rb	Adds a predicate reading the published save-and-return setting.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The unordered document lookup can use an older live version’s save-and-return setting, causing incorrect confirmation warnings when settings differ across versions.

1 open issue

• Read save-and-return settings from the latest live form version · New

1 resolved since last review

• Test save-and-return eligibility against the published form snapshot

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the save-and-return warning updates.

No open issues 🎉

1 resolved since last review

• Read save-and-return settings from the latest live form version

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

When save and return is enabled, the English-only publishing flow omits the warning that saved users can submit the previous version for up to 30 days.

1 open issue

• Add save-and-return warning to English-only live form publishing · New

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the save-and-return publishing and archiving guidance changes.

1 open issue

• Add save-and-return warning to English-only live form publishing

_{Review effort: Balanced}

[github-actions]

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3279.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.