Fix rendering outside a web request in non TEST env (#60) - #61
Open
billgonemad wants to merge 5 commits into
Open
billgonemad wants to merge 5 commits into
billgonemad wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
Problem
Since 364bd4e,
RenderEnvironmentonly bound a web request in the TEST environment. In production/development, rendering off-request (jobs, async tasks, BootStrap) NPE'd as soon as a template used a taglib.Fix
GrailsWebRequestover Grails' servlet-freePageRendererstubs (the same onesgroovyPageRendereruses). It uses the real context path and runs request-scoped cleanup.session,flash,paramsand request attributes keep working. Onlyout, the locale resolver andWrappedResponseHolderare swapped, and they are restored afterwards.Behaviour change
Off-request,
session,withoutgrails.serverURLthrowUnsupportedOperationExceptionin all environments. They already NPE'd in production on 7.0.x, but in TEST they used to work, so downstream test suites may notice. Setgrails.serverURL`.Testing
New integration specs force
grails.env=production, since TEST hid the bug. 14 of the 18 new tests fail against 7.0.x../gradlew check build docs :example:integrationTest: 90 tests, 0 failures.