Repository navigation
Accept ImageSharp findings pulled in by Scryber.Core in Trivy scans - #929
Merged
Merged
Conversation
Scryber.Core pins SixLabors.ImageSharp 3.1.12 up to its latest release, and the fix only exists in 4.1.2. The affected TIFF CCITT encoders and HistogramEqualization are not reachable from GrandNode or Scryber, so the three CVEs are ignored until 2027-01-16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
Issue
The Trivy workflow (#927) reports three HIGH findings in
SixLabors.ImageSharp3.1.12: CVE-2026-106110, CVE-2026-106113 and CVE-2026-106115, fixed in 4.1.2. ImageSharp is not referenced by GrandNode. It comes in transitively throughScryber.Core(PDF generation), which pins 3.1.12, including in its latest release 9.7.5. There is no compatible fix to update to: forcing 4.x, a major version with API changes, under a library built against 3.x risks runtime failures in PDF generation.Solution
New
.trivyignoreat the repository root (Trivy reads it by default, so the workflow is unchanged), with the three CVEs and the reasoning:HistogramEqualization.Scryber.Imagingonly usesTiffFormat,TiffMetadataandDecoderOptions(format detection and decoding). It has no encoder and no histogram processing (checked in the 9.7.4.4 assemblies).Each entry has
exp:2027-01-16. After that date Trivy reports the findings again, so the decision has to be reviewed. Drop the entries once Scryber.Core moves to ImageSharp 4.1.2 or later.The ignore file applies to the SARIF output too, so these findings will not show up in Code scanning while the entries are valid.
Breaking changes
None.
Testing
.trivyignoreand theSystem.Security.Cryptography.Xmlbump from Update System.Security.Cryptography.Xml to 10.0.13 #928, run locally with Trivy 0.70.0:trivy fs --scanners vuln,misconfig,secret --severity HIGH,CRITICAL --ignore-unfixed --exit-code 1 --ignorefile .trivyignore .on a tree with built projects (bin/**/*.deps.json). Exit code 0.Grand.Business.Common.deps.json.Trivyworkflow ondevelopshould pass, unless the image job finds something in the base image OS packages.