Pass an explicit context to the checkout services

[KrzysztofPajak]

Type: feature

Issue

The checkout services in Grand.Business.Checkout read the customer, store, currency, tax display, language and request host from WorkContext / StoreContext: PlaceOrderCommandHandler, ShoppingCartService, ShoppingCartValidator, CheckoutAttributeService, CheckoutAttributeFormatter, and the cart-merging CustomerLoggedInEventHandler. Their results therefore depended on who called them, and outside a request they had no values to read. Follows #930 (catalog, CatalogAccess) and #931 (pricing, tax and checkout calculation), both merged into develop.

Solution

Nothing in Grand.Business.Checkout reads IContextAccessor any more. Callers pass the values; Web takes them from its request.

• PlaceOrderCommand carries a CalculationContext, the fallback Language, the store Host and OriginalCustomerIfImpersonated. The checkout page fills them from its request, and PlaceOrderContainer carries the context. This removes PR 2's temporary AmbientCalculationContext.
• OrderNotificationCommand carries Customer and OriginalCustomerIfImpersonated instead of the whole IWorkContext.
• ICheckoutAttributeFormatter.FormatAttributes(attributes, CalculationContext, Language, DomainHost, …).
• ICheckoutAttributeService.GetAllCheckoutAttributes(CatalogAccess, excludeShippableAttributes), the same access object the catalog read services take since Pass customer and store explicitly to catalog read services #930: CatalogAccess.For(customer, storeId) on the storefront, CatalogAccess.IncludingHidden(storeId) in the admin panel. The storeId, customer and ignoreAcl parameters are gone.
• IShoppingCartValidator.GetShoppingCartWarnings(cart, checkoutAttributes, CalculationContext, …). CheckCommonWarnings and GetRequiredProductWarnings now use the customer and store id they already received.
• IShoppingCartService.GetShoppingCart(customer, storeId, …) and MigrateShoppingCart(from, to, storeId, includeCouponCodes).
• CustomerLoggedInEvent(customer, previousCustomer, storeId). Each of the four publishers reads the signed-in customer and the store on the line where it publishes, which is the same moment the handler used to read them.
• The storefront cart handlers (GetShoppingCartHandler, GetMiniShoppingCartHandler, GetAddToCartHandler, and the cart warnings in GetWishlistHandler) now use their own request values instead of the request context. They are the same values, because every sender fills them from the current request.

Deliberate behavior changes:

• Checkout attribute cache: the all-attributes cache key held the store, the shippable flag and the ACL flag, but not the customer groups the ACL filter used. The first customer's filtered list was then served to every customer of the store, so attributes limited to a group were shown to, or hidden from, the wrong customers. The key now includes the group ids, as the Catalog keys do (separate commit).
• Admin condition picker: on the admin checkout attribute page, the condition dropdown filtered attributes by the staff member's own groups, so attributes limited to other groups could not be picked as a condition. It now lists all of them, like the attribute list on the same page. This change lands in the explicit-customer commit: AdminShared has no request customer to pass, so the new signature forces it.
• Required-products check: the check for products that require other products now looks at the cart of the customer it is given, not the cart of whoever made the request. For a shared wishlist it checks the owner's wishlist, not the visitor's. For an admin editing a customer's cart, it checks the customer's cart, not the admin's own.
  • The login cart merge checks required products against the guest cart, which holds the whole set being moved, and adds each item to the account without the check (separate commits). Checking the account's cart would fail before the required product arrived, and the item would be dropped with the guest cart. Before this branch the check saw the guest's full cart, so the outcome is unchanged.

Not in this PR: ProductAttributeFormatter (follow-up PR), and ExternalAuthenticationService, which still reads the request context itself (PR 4).

Breaking changes

• Every signature listed above changed. Plugins that call these methods, publish CustomerLoggedInEvent or send PlaceOrderCommand must pass the new values and be rebuilt. PlaceOrderCommand.Context, Language and Host are required.
• OrderNotificationCommand.WorkContext is removed.
• Validator records: ShoppingCartRequiredProductValidatorRecord.Store became StoreId, and ShoppingCartCommonWarningsValidatorRecord lost its unused Store.
• Constructors: PlaceOrderCommandHandler, ShoppingCartService, ShoppingCartValidator, CheckoutAttributeService, CheckoutAttributeFormatter and CustomerLoggedInEventHandler no longer take IContextAccessor.

Testing

1. dotnet build GrandNode.slnx
2. dotnet test GrandNode.slnx: green.
3. New tests:
   • CheckoutAttributeServiceTests:
     • GetAllCheckoutAttributes_FiltersByTheGroupsOfTheGivenCustomer
     • GetAllCheckoutAttributes_CacheKeyDependsOnTheCustomerGroups
     • GetAllCheckoutAttributes_IncludingHidden_ReturnsGroupLimitedAttributes
   • CheckoutAttributeViewModelServiceTests.PrepareConditionAttributes_OffersAttributesLimitedToCustomerGroups: pins the CatalogAccess.IncludingHidden() call, which the real service's ACL tests cover
   • CheckoutAttributeFormatterTests: context currency and tax display, translated names, file link host
   • ShoppingCartValidatorTests
   • ShoppingCartServiceTests:
     • GetShoppingCart_ReturnsTheItemsOfTheGivenCustomer
     • MigrateShoppingCart_MovesCheckoutAttributesOfTheGivenStore
     • MigrateShoppingCart_DoesNotRequireRequiredProductsInTheTargetCartYet
     • MigrateShoppingCart_ChecksRequiredProductsAgainstTheSourceCart
   • CustomerLoggedInEventHandlerTests.Handle_MigratesFromThePreviousCustomerInTheEventStore
   • PlaceOrderCommandHandlerTests, OrderNotificationCommandHandlerTests
4. Manual test on a local store:
   • a guest added an item and chose gift wrapping, then logged in, and the cart and the choice moved to the account
   • orders placed in EUR and in USD with 23% tax and gift wrapping
   • the storefront order details, the admin order page and both order emails agree on every amount
   • the admin condition picker lists the other attributes

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.