Repository navigation
test: replace real client identifiers with generic placeholders - #632
Conversation
Replace real client and private project names, private host references, a personal home path and private tracker links in fixtures, test names, docs, comments and benchmark protocol labels with neutral placeholders. Test intent and expectations are unchanged. The edited docs snapshot hash in the docs manifest is updated to match. History is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The example projects tracked Hack-generated compose overrides under `.hack/.internal/`, which hold machine-local paths and must not be hand-edited. Remove them from version control and ignore generated `.hack/.internal/` and `.hack/.branch/` state at any depth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a87f016824
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Conflicted files take the next side; the placeholder pass is redone in the following commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Replaces real client and private project names, private development-host references, one personal home path and private tracker links in the current tree with neutral placeholders (
example-app,sample,example_qa,large-application, hosts underexample.test,/Users/example).Files changed by kind:
tests/*.test.ts, one e2e scenario, one test helper comment): project, branch, compose, session and profile names.#[ignore]reasons and evidence strings inpackages/runtime-core. Only test code changed. Ports, hostname shapes and assertions are the same.scripts/application-benchmark-protocol.json, its checker and the Python test): the workload id is renamed. Its shape, pin and correctness checks are unchanged.scripts/docs/versions.json.src/lib/project.ts(comment only).examples/*/.hack/.internal/: a home path in a mount source.CHANGELOG.mdlines.No production code special-cased these names. History is unchanged: no rewrite and no force-push.
Validation
bun teston every touched TS test file: 232 pass, 0 fail.bun run --cwd packages/cli typecheckandcheck: pass.bun run privacy:check: ok.bun run docs:prepare && bun run docs:check: pass.cargo +1.97.1):fmt --check,clippy --all-targets -D warningsandcargo test --locked: 1313 passed, 0 failed, 109 ignored.python3 scripts/check-application-benchmark-protocol.py: valid.python3 -m unitteston the protocol test: 45 OK.gitleaksover the new commit: no leaks.Update: merged with
nextnextwas merged in (merge commit takes thenextside for the one textual conflict, a Rust test thatnexthad already moved and renamed to the same placeholder name). The placeholder pass was then rerun over the whole merged tree with the full identifier checklist from this PR's diff. It found no remaining occurrences, so no extra scrub commit was needed: the batches merged since this PR was opened added none, and every replacement line from the original commit survives the merge.Validation on the merged head:
bun teston the 17 touched TS test files: 234 pass, 0 fail.bun run --cwd packages/cli typecheck(clean worktree) andcheck: pass. Biome on changed files: clean.bun run privacy:check: ok.bun run docs:prepare && bun run docs:check: pass.1.97.1):fmt --checkandcheck:local(clippy--all-targets -D warnings): pass. Affected lib tests andproject_contract: 144 lib tests and 66 contract tests passed, 0 failed.python3 -I scripts/check-application-benchmark-protocol.py: valid. Protocol unittest: 45 OK.gitleaksover the new commits and the tree: no leaks.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.