Repository navigation
feat: 🎸 v4.0.0 with lemmy memes, native fetch and cli - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
random()returned the same hardcoded meme on every call, because the API behind it has served a dummy response since 2024-03-03. It now reads Lemmy directly.Also: Node >= 20 with zero runtime dependencies, Jest replaced by
node:testwith mockedfetch, CI on Node 20/22/24, updated Pages and publish actions, community health files. Full list inCHANGELOG.md.Evidence
About my uncle.npm auditreports 27 vulnerabilities (1 critical, 15 high, axios in production).import { random } from "random-memes"finds onlydefault.After: five CLI runs print five different memes. Eight calls in one process return eight distinct memes, 281 ms for the first and 0 ms for the cached rest.
npm audit --omit=devfinds 0. ESM named import works.npm testpasses 19/19 offline andnpm run test:typespasses.Merge Danger
Door: two-way for the repo. Publishing 4.0.0 to npm afterwards is one-way, since a version number cannot be reused.
Blast Radius: consumers
Major version: Node >= 20 is required, the
exportsmap blocks deep imports, andcategoryis now the Lemmy community name. 3.x installs are untouched until they upgrade.