Repository navigation
Upgrade Rspress to 2.1.2 - #635
Merged
Merged
Conversation
- Bump @rspress/core from ^2.1.0 to ^2.1.2. - Drop the explicit transformerNotationDiff since Rspress 2.1.1 enables the Shiki notation transformers by default, and remove the now-unused @shikijs/transformers dependency. - Allow the new Rspress versions in minimumReleaseAgeExclude. Co-authored-by: OpenBot <335604065+openbotgit[bot]@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | e0f2a2f | Commit Preview URL Branch Preview URL |
Nov 11 2026, 11:17 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Bumps
@rspress/corefrom2.1.0to2.1.2.2.1.1: enables the Shiki notation transformers (transformerNotationHighlight,transformerNotationDiff, etc.) by default and re-exports all@shikijs/transformershelpers from@rspress/core/shiki-transformers. The config already importedtransformerNotationDiffexplicitly, so it is removed and@shikijs/transformersis dropped fromdependencies.2.1.2: adds "View as Markdown" in the Markdown menu, more built-in theme translations, nested sidebar layout refinements, and search/dropdown accessibility fixes.Verification
pnpm install→@rspress/core 2.1.2; the lockfile still carries@shikijs/transformers 4.5.0as a transitive dependency, and no source file references it any more.pnpm buildpasses and exits0: 255 Markdown outputs, 256 HTML files (including 404) and a 255-entry sitemap, matchingmain. The generated.mdfiles are byte-identical to a2.1.1build; againstmain(2.1.0) only 5 files / 10 lines differ, all Markdown escaping (\_→_,\@→@, trailing spaces → ).pnpm check:ci(Rslint + Rsfmt) passes.```yaml {2-3}), search (⌘K) and client-side navigation, which all still work.CLEAN.Known issue
Rspress
2.1.2logsReferenceError: window is not definedsix times while rendering the Markdown export pages (the__ssg_md__pass). The cause is inuseStorageValue: theuseSyncExternalStorerefactor in web-infra-dev/rspress#3851 callswindow.addEventListenerinside thesubscribecallback without a server guard. The call chain here isClientApp → useThemeState → useStorageValue.subscribe, i.e. the theme's appearance preference — not the GitHub social link, which usesmode: "link"and never renders the star count.Measured:
2.1.0= 0 occurrences,2.1.1= 0,2.1.2= 6. Adding atypeof windowguard to the installeduseStorageValue.subscribedrops it to 0 and restoring it brings the 6 back, which confirms the source. It is noisy rather than breaking: the build exits0, every page is still generated, and only the Markdown export pass is affected. Worth reporting upstream; pinning to2.1.1is the fallback if it ever becomes blocking.pnpm-workspace.yamlkeeps a staleminimumReleaseAgeExcludeentry for@rspress/core@2.1.0, which is now unused and harmless.🤖 Generated with OpenBot