Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The wire-protocol status changes require a synchronized rollout, but the inaccessible backend changes leave enum compatibility, stored-state migration, and cross-agent compatibility requiring human confirmation.
No open issues 🎉
What changed in this PR
Aligns the Python agent’s reported states with raw hashcat status codes, removing the one-value offset. This supports the coordinated backend and agent update referenced in hashtopolis/server#2517.
Changes:
- Returns raw hashcat status codes and adds regression coverage.
- Updates hashcat keepalive and completion checks to use unshifted codes.
- Aligns generic cracker progress reports with the same status numbering.
| File | Description |
|---|---|
tests/test_hashcat_status.py |
Adds coverage for raw status-code passthrough. |
htpclient/hashcat_status.py |
Removes the status offset and documents raw-code behavior. |
htpclient/hashcat_cracker.py |
Updates keepalive and completion status values. |
htpclient/generic_cracker.py |
Updates running and completed progress-report states. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python agent part of hashtopolis/server#2517
Note: needs to be synchronously merged with backend, frontend and other agents