Skip to content

Align hashcat status without the 1 offset fix - #82

Draft
s3inlc wants to merge 1 commit into
masterfrom
2517-align-hashcat-status
Draft

s3inlc wants to merge 1 commit into
masterfrom
2517-align-hashcat-status

Conversation

@s3inlc

@s3inlc s3inlc commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

python agent part of hashtopolis/server#2517

Note: needs to be synchronously merged with backend, frontend and other agents

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The wire-protocol status changes require a synchronized rollout, but the inaccessible backend changes leave enum compatibility, stored-state migration, and cross-agent compatibility requiring human confirmation.

No open issues 🎉

What changed in this PR

Aligns the Python agent’s reported states with raw hashcat status codes, removing the one-value offset. This supports the coordinated backend and agent update referenced in hashtopolis/server#2517.

Changes:

  • Returns raw hashcat status codes and adds regression coverage.
  • Updates hashcat keepalive and completion checks to use unshifted codes.
  • Aligns generic cracker progress reports with the same status numbering.
File Description
tests/​test_hashcat_status.py Adds coverage for raw status-code passthrough.
htpclient/​hashcat_status.py Removes the status offset and documents raw-code behavior.
htpclient/​hashcat_cracker.py Updates keepalive and completion status values.
htpclient/​generic_cracker.py Updates running and completed progress-report states.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants