Repository navigation
Expand the editable install tests and label test output - #659
Merged
Merged
Conversation
Ports the applicable editable fixture improvements from the classic buildpack (heroku/heroku-buildpack-python#2155) to the CNB's `pip_editable_git_compiled`, `poetry_editable_git_compiled` and `uv_editable_git_compiled` fixtures and tests: - Every fixture now installs the current project in editable mode, using the package manager's default build backend and src layout. Previously only uv did, the pip fixture had only the VCS requirement, and the Poetry fixture used `package-mode = false`. - Each test now checks at launch-time that the project's entrypoint script is on `PATH` and runs from the app source directory (so the install really is editable), and that the compiled VCS package is imported from the expected location. Previously only the Poetry test checked anything at launch-time. - The `extension.dist` VCS dependency is updated from wheel `0.44.0` to `0.45.1` (the newest tag that still contains it), to match the classic fixtures. The Poetry test now also expects the informational setuptools `BuildBackendWarning` that's emitted when installing the flat-layout VCS package in editable mode, since the new assertion continues past it (the old one ended just before it). Unlike the classic buildpack, the CNB doesn't rewrite editable install paths (the build and launch paths are identical), so the classic fixtures' additional build backend/layout packages and path rewriting checks haven't been ported. In addition: - The testing buildpack and launch-time check output is now labelled (for example `Build-time env vars:`, `Python sys.path:` and `typing_extensions imported from: ...`), so that the asserted output is easier to understand. - "run-time" in comments has been changed to "launch-time", to match the CNB spec's terminology, and the fixture and test comments have been made consistent. GUS-W-24469384.
edmorley
marked this pull request as ready for review
November 9, 2026 20:02
edmorley
enabled auto-merge (squash)
November 9, 2026 20:02
edmorley
added a commit
to heroku/heroku-buildpack-python
that referenced
this pull request
Nov 9, 2026
Ports the test output labelling from the CNB (heroku/buildpacks-python#659), so that the asserted output is easier to understand. This covers the inline buildpack output in the `*_basic` fixtures, the basic tests' `app.run` env var checks, and the paths printed by the editable fixtures' `test-editable-installs.sh`. The editable fixture and test comments have also been updated to match the CNB's wording. GUS-W-24469384.
colincasey
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the applicable editable fixture improvements from the classic buildpack (heroku/heroku-buildpack-python#2155) to the CNB's
pip_editable_git_compiled,poetry_editable_git_compiledanduv_editable_git_compiledfixtures and tests:package-mode = false.PATHand runs from the app source directory (so the install really is editable), and that the compiled VCS package is imported from the expected location. Previously only the Poetry test checked anything at launch-time.extension.distVCS dependency is updated from wheel0.44.0to0.45.1(the newest tag that still contains it), to match the classic fixtures.The Poetry test now also expects the informational setuptools
BuildBackendWarningthat's emitted when installing the flat-layout VCS package in editable mode, since the new assertion continues past it (the old one ended just before it).Unlike the classic buildpack, the CNB doesn't rewrite editable install paths (the build and launch paths are identical), so the classic fixtures' additional build backend/layout packages and path rewriting checks haven't been ported.
In addition:
Build-time env vars:,Python sys.path:andtyping_extensions imported from: ...), so that the asserted output is easier to understand.GUS-W-24469384.