Repository navigation
fix(vpto): 暂时关闭 BiSheng 错误的 UB dead store 消除 - #1774
Closed
mouliangyu wants to merge 1 commit into
Closed
mouliangyu wants to merge 1 commit into
mouliangyu wants to merge 1 commit into
Conversation
Collaborator
Author
|
目标平台应为 GitLab;此 GitHub PR 开错位置,现关闭。代码改动保留在提交 26efc78。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修复
BiSheng 的 UB dead store elimination 会把同址、互补 mask 的后一次向量写误认为完整覆盖前一次写,导致有效 lane 没有写入 UB(见 #1762)。VPTO 向量设备 LLVM 编译现默认传入
-mllvm -cce-vf-enable-ub-dead-st-elimination=false,暂时关闭该优化,直到 BiSheng 修复 mask 覆盖判断。参数在共用的设备编译入口添加,覆盖 scheduler on/off/auto 和设备对象输出;cube 编译路径不受影响。扩展 lit 检查,验证不同 scheduler 模式下的 BiSheng 命令均携带该参数。
验证
git diff --check:通过。ObjectEmission.cpp编译通过。新工作树首次全量构建耗时较长,未完成本地 lit;完整构建与测试由 PR CI 执行。关闭 UBDSE 可能增加部分 UB store。代表性向量 kernel 的性能影响尚未量化。
Closes #1762