Repository navigation
[#436] Integrate history endpoints - #492
Merged
Merged
Conversation
Mount app immediately then async load API data
371 site edit cancel
Start editing opens a chooser of the source's managed datastreams and their sessions: continue an in-progress session, start a new one over the selected time range, or create and delete managed datastreams. Managed datastreams are hidden from the catalog and reached through the chooser. Also adds inline processing-level creation, the session description captured at commit time, reuse of the source's loaded series as the working copy, clamping the session window to the source extent, and session resume that replays saved operations.
…eps nested relations
…-endpoints # Conflicts: # package-lock.json
Maurier
marked this pull request as draft
August 3, 2026 22:29
Plot a QC session's state at any operation as a separate, frozen line so it can be compared against the session being edited. Buttons sit on every operation row and on the "Data loaded" row, which plots the state the session started from. Snapshots ride in plottedDatastreams under the synthetic id snap:<sessionId>:<opIndex>, so legend rendering, colour assignment, visibility and reorder work unchanged. isSnapshotId guards the paths that would otherwise treat one as real: refreshGraphSeriesArray skips its fetch, releaseManagedDatastream drops them when the editor closes, and the share encoder keeps them out of ds in favour of its own snap key. The base is always the session chain's own window, never the plot's time range, because operations replay against array indices. Snapshots build on a detached ObservationRecord since the observation store hands back one shared instance per datastream and the replay mutates what it is given. Also fixes two pre-existing problems in the history panel that this work surfaced: - Reloading from a step restored the pre-replay entries wholesale, which put the old timings back over the ones the replay had just measured. Only the "Data loaded" row updated. The panel now keeps the replayed entries and appends only what the replay dropped. - hasUnsavedChanges compared entries by identity, so a replay while viewing a committed session read as pending edits and prompted "You have unsaved edits". A committed session cannot be edited, so both it and unsavedEditCount now short-circuit on isReadOnly.
Covers the feature in the user guide, the id convention, guards and detached-fetcher rule in the architecture doc, the axis behaviour in the plotting doc, and the two new store actions in the API reference.
The Data loaded row is step -1, so a session's starting state is now reachable the same way any operation is, and it carries the "Showing" chip when it is the step on screen. Its reload-from-server button moves to a cloud icon so the row no longer shows two identical glyphs doing different things: one replays the history to a step, the other refetches and drops the history.
Save, Commit and Close now sit in a footer below the history and stay visible while it is collapsed. Also drops the author name from collapsed rows, puts the comment icon beside the operation title, and retitles reload-from-server to discard and reload, hidden on committed sessions.
… into 436-integrate-history-endpoints
…-endpoints # Conflicts: # django/contracts/openapi/auth.openapi.json # django/contracts/openapi/data.openapi.json # django/hydroserver/__init__.py # packages/hydroserverpy/setup.cfg
…ate-history-endpoints
Undo, redo, step reload, and removing an entry all rebuild each item from its method and args, which dropped the operator's comment and the server's attribution. Re-stamp both afterwards, paired positionally and only when the method still matches. Execution timings are left to be re-measured.
Deleting removes descendants first so each delete meets the server's no-dependents rule. The confirmation names every session going and asks for an acknowledgement when the cascade reaches past the one picked. Also in the editor: session actions sit in a container in the edit history footer, with Discard and a New session action after a commit; history steps replay by clicking the row instead of a button; steps after the one shown are dimmed; and the chooser lists sessions as a timeline.
… into 436-integrate-history-endpoints
…tle in edit selection spec This commit should resolve the broken e2e tests for the QC app
…ate-history-endpoints
Contributor
Author
|
@daniel-slaugh - This should be ready for another round. I tested some more yesterday and fixed some regressions:
|
daniel-slaugh
approved these changes
Oct 6, 2026
daniel-slaugh
left a comment
daniel-slaugh
left a comment
Contributor
There was a problem hiding this comment.
All looks good! I ran through the blockers I flagged in the Review Doc and all are either resolved or in a stable position ready for a followup PR in a post v1.12 release.
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates QC history and session management end to end.