refactor(client): replace SyncWrapper with sync_wrapper crate - #335
Merged
Merged
Conversation
the `common::sync` module contains a type called `SyncWrapper`, which provides an interface that permits for safely treating a `T` that is not `Sync`, as `Sync`. this exists as a public crate, `sync_wrapper` that we can use instead. this crate is used by `reqwest`, `tower`, `axum`, `tonic`, and other popular crates. Co-authored-by: katelyn martin <git@katelyn.world>
cratelyn
marked this pull request as ready for review
September 30, 2026 20:19
cratelyn
added
C-chore
Member
Author
|
noting for reviewers, because this is connected to the legacy client, i'd be happy accepting this or discarding it. opening this as a new pull request was the easiest way to resolve conflicts and get #118 into a clean state in which it could be merged. |
seanmonstar
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#118 had conflicts with the current state of
master. it looked likea reasonable change to me, so this rebases that work onto the current
state of master.
the
common::syncmodule contains a type calledSyncWrapper, whichprovides an interface that permits for safely treating a
Tthat is notSync, asSync.this exists as a public crate,
sync_wrapperthat we can use instead.this crate is used by
reqwest,tower,axum,tonic, and otherpopular crates.