chore(client/legacy): remove disabled client_happy_eyeballs test - #336
Merged
Merged
Conversation
this test was completely disabled in #65. because this test is always disabled, this can be removed. fixes the following warning: ``` ; cargo test --features full Compiling hyper-util v0.1.21 (/hyper-util) warning: unused attribute --> src/client/legacy/connect/http.rs:1189:66 | 1189 | #[cfg_attr(not(feature = "__internal_happy_eyeballs_tests"), ignore)] | ^^^^^^ help: remove this attribute | note: attribute also specified here --> src/client/legacy/connect/http.rs:1188:5 | 1188 | #[ignore] // TODO | ^^^^^^^^^ = note: `#[warn(unused_attributes)]` (part of `#[warn(unused)]`) on by default ``` Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
marked this pull request as ready for review
September 30, 2026 22:26
cratelyn
added
C-chore
cratelyn
commented
Sep 30, 2026
Comment on lines
-1187
to
-1190
| #[test] | ||
| #[ignore] // TODO | ||
| #[cfg_attr(not(feature = "__internal_happy_eyeballs_tests"), ignore)] | ||
| fn client_happy_eyeballs() { |
Member
Author
There was a problem hiding this comment.
i note the TODO here, so we could alternatively comment out the cfg_attr line instead. this has been inactive for almost 3 years now however, so deleting seemed like the pragmatic choice to me.
seanmonstar
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test was completely disabled in #65. because this test is always
disabled, this can be removed.
fixes the following warning: