style: remove useless_borrows_in_formatting from the clippy allowlist - #4220
Merged
seanmonstar merged 1 commit intoOct 2, 2026
Merged
seanmonstar merged 1 commit into
seanmonstar merged 1 commit into
Conversation
Fix the two remaining violations in src/proto/h1/decode.rs by inlining the header variable into the format string, which also satisfies the uninlined_format_args lint that the old &header borrow was dodging. Refs: hyperium#4071
seanmonstar
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the strict clippy effort in #4071 — this takes the
useless_borrows_in_formattinglint off the "lints to decide on" list.The two remaining violations were in
src/proto/h1/decode.rs, in the error paths of trailer header parsing:The
&borrow was redundant for the format argument, but simply dropping it would then tripuninlined_format_args(the borrow was dodging it, since&headeris not a bare identifier). Inlining the variable satisfies both lints:cargo clippy --features fullreports no violations of either lint.cargo test --features full --lib: 117 passed, 0 failed.