Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c692533
fix(ci): regenerate actions.lock entries so CI starts again; guard drift
HoTT-stuff Nov 19, 2026
fe174af
style(ci): [[ ]] tests and named locals in check-actions-lock.sh (Son…
HoTT-stuff Nov 19, 2026
7fa3736
fix(ci): actions.lock guard sees flow-style steps and transitive depe…
HoTT-stuff Nov 19, 2026
71ac72e
fix(ci): actions.lock guard reads quoted uses keys, ignores run-scrip…
HoTT-stuff Nov 19, 2026
97f8623
style(ci): quote the joined lists in check-actions-lock.sh messages (…
HoTT-stuff Nov 19, 2026
b18fb9e
fix(ci): actions.lock guard allows space before the uses colon
HoTT-stuff Nov 19, 2026
57f6e23
fix(ci): actions.lock guard keeps refs whose branch contains /
HoTT-stuff Nov 19, 2026
1d2b480
fix(ci): actions.lock guard fails closed on unreadable uses values
HoTT-stuff Nov 19, 2026
7fc0186
fix(ci): tell reusable-workflow calls from steps by context, not path
HoTT-stuff Nov 19, 2026
e3eb086
style(ci): name positional parameters in tag()/refs() (Sonar S7679)
HoTT-stuff Nov 19, 2026
5ede7ec
fix(ci): keep indentless step sequences in step context; add guard se…
HoTT-stuff Nov 19, 2026
15fe522
fix(ci): hold OCaml at 4.14 on Ubuntu 26.04 runners
HoTT-stuff Nov 19, 2026
ebdf44c
docs(changelog): record the OCaml 4.14 CI toolchain fix
HoTT-stuff Nov 19, 2026
8c9a09f
fix(tea): import node and create in the Todo example the e2e test drives
HoTT-stuff Nov 19, 2026
cf511fb
fix(tea): also import patch for the Todo e2e keyed-diffing test
HoTT-stuff Nov 19, 2026
d98edf6
fix(ci): trim trailing whitespace in uses: values before checking
HoTT-stuff Nov 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions .claude/CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,20 @@ resolved; kept here with current status so agents don't re-investigate:
root files. A real new finding shows as a *delta in your changed files*;
otherwise ignore. (The Hypatia *check run* gates separately and is green.)

**CI is now standalone and green on `main` (since #604 / `c7922cf`).** Two
`startup_failure` classes bit `ci` / `governance` / `secret-scanner` for days
(and `main` itself) — worth knowing so they aren't reintroduced:

1. The repo's Actions "allowed actions" policy **rejects tag-pinned action
refs at run-creation** (a `startup_failure` with zero jobs). **Pin every
`uses:` to a full commit SHA** — `actions/foo@v4` will fail to start.
**CI is standalone (since #604 / `c7922cf`).** Two `startup_failure` classes
(a run that never starts, with zero jobs) have bitten `ci` / `governance` /
`secret-scanner` and `main` itself. `ci` did not run at all from
2026-10-11 until the actions.lock fix. Know them so they aren't reintroduced:

1. **`.github/workflows/actions.lock` is the pin authority** (GitHub's actions
lockfile, `gh actions-lock`). Workflows reference actions by tag
(`actions/checkout@v7.0.1`) and the lock maps each to a commit SHA. A
workflow whose `uses:` refs do not match the lock does not start. A
Dependabot bump that does not regenerate the lock causes exactly this
(#782 stopped `ci`). **After any change to a `uses:` ref, regenerate
`actions.lock`.** `tools/ci/check-actions-lock.sh` (governance check 4)
fails on a mismatch. (An older note here said tag pins themselves were
rejected; the run history shows tag pins that match the lock start fine.)
2. A reusable-workflow *caller* that declares `concurrency:` on the same key
the reusable also declares is rejected at run-creation (BP008 — see
`.github/workflows/spark-theatre-gate.yml`).
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/actions.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ workflows:
- 'actions/configure-pages@v6.0.0'
- 'actions/deploy-pages@v5.0.1'
- 'actions/upload-pages-artifact@v5.0.0'
- 'haskell-actions/setup@v2.12.0'
- 'haskell-actions/setup@v2.12.1'
'.github/workflows/ci.yml':
- 'actions/checkout@v7.0.1'
- 'actions/setup-node@v7.0.0'
- 'actions/upload-artifact@v7.0.1'
- 'actions/setup-node@v7.1.0'
- 'actions/upload-artifact@v7.0.2'
'.github/workflows/codeql.yml':
- 'actions/checkout@v7.0.1'
- 'github/codeql-action@v4.39.3'
Expand All @@ -40,7 +40,7 @@ workflows:
- 'actions/upload-pages-artifact@v5.0.0'
'.github/workflows/panic-attack.yml':
- 'actions/checkout@v7.0.1'
- 'actions/upload-artifact@v7.0.1'
- 'actions/upload-artifact@v7.0.2'
- 'dtolnay/rust-toolchain@master'
'.github/workflows/publish-jsr.yml':
- 'actions/checkout@v7.0.1'
Expand Down Expand Up @@ -92,19 +92,19 @@ dependencies:
commit: 'sha1-368f82528645a54fb793d4d04e342629a3f51346'
owner_id: 44036562
repo_id: 438112499
'actions/setup-node@v7.0.0':
ref: 'v7.0.0'
commit: 'sha1-820762786026740c76f36085b0efc47a31fe5020'
'actions/setup-node@v7.1.0':
ref: 'v7.1.0'
commit: 'sha1-949feb2413d6458794dcd2491c4babbbce0c15c1'
owner_id: 44036562
repo_id: 189476904
'actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f':
ref: 'v7.0.0'
commit: 'sha1-bbbca2ddaa5d8feaa63e36b76fdaad77386f024f'
owner_id: 44036562
repo_id: 192625955
'actions/upload-artifact@v7.0.1':
ref: 'v7.0.1'
commit: 'sha1-043fb46d1a93c77aae656e7c1c64a875d1fc6a0a'
'actions/upload-artifact@v7.0.2':
ref: 'v7.0.2'
commit: 'sha1-cf430e030ddbb5b0abf93d22962f4752f3646cd9'
owner_id: 44036562
repo_id: 192625955
'actions/upload-pages-artifact@v5.0.0':
Expand All @@ -129,9 +129,9 @@ dependencies:
commit: 'sha1-33d7b85da1a04171e211befe2c739303b9a4c066'
owner_id: 9919
repo_id: 259445878
'haskell-actions/setup@v2.12.0':
ref: 'v2.12.0'
commit: 'sha1-6037f33647c3f17758a2356c80fc4a53d7e0685d'
'haskell-actions/setup@v2.12.1':
ref: 'v2.12.1'
commit: 'sha1-0f8e8c99d88aeb3fbfd523f1ef2c6f762d10d64d'
owner_id: 75048950
repo_id: 623796603
'hyperpolymath/smtp-notify-action@v0.5.1':
Expand Down
57 changes: 19 additions & 38 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@
#
# Standalone CI: no dependency on third-party actions or external-repo
# reusable workflows. The OCaml toolchain is self-hosted via apt + opam
# (replacing ocaml/setup-ocaml), and only first-party `actions/*` are used
# (checkout / setup-node / upload-artifact), SHA-pinned. dune-project requires
# OCaml >= 4.14, satisfied by the runner's apt OCaml (ocaml-system), with a
# base-compiler fallback.
# (replacing ocaml/setup-ocaml) in tools/ci/setup-ocaml.sh, and only
# first-party `actions/*` are used (checkout / setup-node / upload-artifact).
# OCaml is held at 4.14: dune-project needs >= 4.14 and the with-test
# dependency bisect_ppx needs < 5.0, so the runner's apt OCaml is used only
# when it is 4.14.x (Ubuntu 26.04 ships 5.4) and a pinned
# ocaml-base-compiler.4.14.2 is built otherwise.
#
# NOTE on pins: first-party `actions/*` are SHA-pinned (repo SHA-pinning
# policy + Hypatia workflow_audit + the "allowed actions" policy that rejects
# tag refs at run-creation). `actions/checkout` is v7.0.0 (`9c091bb…`, bumped
# by Dependabot in #605); `setup-node` / `upload-artifact` remain v4.
# NOTE on pins: `.github/workflows/actions.lock` is the pin authority. Steps
# name actions by tag and the lock maps each to a commit SHA; a workflow
# whose refs do not match the lock never starts (startup_failure, zero
# jobs). Regenerate the lock after any `uses:` change; governance check 4
# (tools/ci/check-actions-lock.sh) fails on drift.
name: CI
on:
push:
Expand Down Expand Up @@ -44,15 +47,8 @@ jobs:
# clone makes property 4 fail closed ("stamp not present").
fetch-depth: 0
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
# Prefer the runner's system OCaml (>= 4.14 satisfies dune-project)
# for an instant switch; fall back to a pinned base compiler.
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Set up Node.js
uses: actions/setup-node@v7.1.0
with:
Expand Down Expand Up @@ -187,13 +183,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v7.0.1
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Install dependencies
# Match the build job: `dune build` compiles everything including
# test/ (which depends on alcotest, with-test) and the @doc target
Expand All @@ -216,13 +207,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v7.0.1
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Install dependencies
run: opam install . --deps-only --with-test --with-doc --yes
- name: Build bench targets
Expand Down Expand Up @@ -266,13 +252,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v7.0.1
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Install dependencies
run: opam install . --deps-only --with-test --with-doc --yes
- name: Set up Node.js
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-jsr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ jobs:
timeout-minutes: 10
steps:
- uses: actions/checkout@v7.0.1
# v2.0.5 — immutable commit pin (tag: v2.0.5).
- uses: denoland/setup-deno@22d081ff2d3a40755e97629de92e3bcbfa7cf2ed
# v2.0.5; its commit is pinned in actions.lock (the pin authority).
- uses: denoland/setup-deno@v2.0.5
with:
deno-version: v2.x
- name: Resolve package directory
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,16 @@ JSR publish (#303)

==== CI

* fix(ci): `CI` never started from 2026-10-11 (startup_failure, zero jobs)
because Dependabot #782 bumped actions in ci.yml without regenerating
`.github/workflows/actions.lock`. The lock now matches every workflow
(ci.yml, panic-attack.yml, casket-pages.yml, publish-jsr.yml), and
governance check 4 (`tools/ci/check-actions-lock.sh`) fails on any drift
* fix(ci): the OCaml jobs (build, lint, bench, coverage) failed on Ubuntu
26.04 runners, which ship OCaml 5.4, because the with-test dependency
`bisect_ppx` needs OCaml < 5.0. `tools/ci/setup-ocaml.sh` uses the runner
OCaml only when it is 4.14.x and otherwise builds a pinned
`ocaml-base-compiler.4.14.2`
* ci(migration-assistant): fix smoke-parse for tree-sitter-cli 0.25
(#342)
* ci: bump github/codeql-action from 4.32.6 to 4.36.0 (#323)
Expand Down
2 changes: 1 addition & 1 deletion affinescript-tea/examples/todo/Todo.affine
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
module Todo;

use prelude::*;
use Tea::{Html, Attr, Cmd, Sub, Event, run, text, div, span, button, input, ul, li, h1, p,
use Tea::{Html, Attr, Cmd, Sub, Event, run, text, node, create, patch, div, span, button, input, ul, li, h1, p,
class, id, value, key, attr, lazy, on_click, on_input, on_enter, on_check, none, send,
every, no_sub, tea_map, tea_filter, run_cmd, tea_defer};

Expand Down
147 changes: 147 additions & 0 deletions tools/ci/check-actions-lock.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
#!/usr/bin/env bash
# SPDX-License-Identifier: MPL-2.0
#
# actions.lock consistency guard.
#
# `.github/workflows/actions.lock` (GitHub's actions lockfile, generated by
# `gh actions-lock`) is this repo's pin authority: it maps every action a
# workflow uses to a commit SHA. GitHub refuses to start a workflow whose
# `uses:` refs do not match the lock, and reports only a `startup_failure`
# with zero jobs. That is how the `CI` workflow stopped running on every
# push and PR from 2026-10-11: Dependabot (#782) bumped
# `actions/setup-node` and `actions/upload-artifact` in ci.yml without
# regenerating the lock.
#
# For each workflow, this check compares the set of external actions its
# `uses:` lines reference (sub-path actions such as
# `github/codeql-action/init@v4` count as `github/codeql-action@v4`; local
# `./` actions, `docker://` images and reusable workflows (a job-level
# `uses:` naming a `.github/workflows/*.yml` file) are not locked)
# with the set the lock lists for it, and fails on any difference, either
# way round. It also fails if a locked action has no `dependencies:` entry.
#
# Usage: tools/ci/check-actions-lock.sh [WORKFLOW_DIR] (default .github/workflows)
set -uo pipefail

dir="${1:-.github/workflows}"
lock="$dir/actions.lock"
fail=0
err() { printf '::error::%s\n' "$*"; fail=1; }

[[ -f "$lock" ]] || { err "actions lockfile missing: $lock"; exit 1; }

# Split a workflow (comments stripped) by context: lines inside a `steps:`
# block (more indented than its `steps:` key) are tagged S, all others J.
# A reusable workflow is called by a job (`jobs.<id>.uses`), never by a step,
# so the reusable-workflow exclusion below applies to J lines only: a step
# action whose directory happens to be named `.github/workflows/x.yml` is
# still checked.
tag() {
local file="$1"
sed -E 's/[[:space:]]+#.*$//; s/[[:space:]]+$//' "$file" | awk '
{ match($0, /^ */); ind = RLENGTH }
/^[[:space:]]*$/ { next }
# An indentless sequence (`steps:` then `- uses: …` at the same indent) is
# still step context: only a non-`-` line at or above the key ends it.
in_steps && (ind < sind || (ind == sind && $0 !~ /^ *-/)) { in_steps = 0 }
/^[[:space:]]*["'\'']?steps["'\'']?[[:space:]]*:/ {
# `steps: [{uses: …}]` (flow sequence on the key line) is step context too.
print (match($0, /:[[:space:]]*[^[:space:]]/) ? "S" : "J") "\t" $0
in_steps = 1; sind = ind; next
}
{ print (in_steps ? "S" : "J") "\t" $0 }
'
}

# The `uses:` values on lines tagged $2 (S or J), action-shaped only.
# Block style (`- uses: x`), flow style (`- {uses: x, with: …}`) and quoted keys (`"uses": x`).
# Only action-shaped values count (`owner/repo[/path]@ref`, a ref may hold `/`), so `uses:` text in
# a `run:` script (a grep pattern, say) is not mistaken for a step.
refs() {
local file="$1" ctx="$2"
tag "$file" | grep -E "^$ctx"$'\t' | cut -f2- \
| grep -oE '(^|[{,[:space:]-])["'\'']?uses["'\'']?[[:space:]]*:[[:space:]]*[^[:space:],}]+' \
| sed -E 's/^.*uses["'\'']?[[:space:]]*:[[:space:]]*//; s/^["'\'']//; s/["'\'']$//' \
| grep -vE '^(\./|docker://)' \
| grep -E '^[A-Za-z0-9_.-]+/[A-Za-z0-9_./-]+@[A-Za-z0-9_./-]+$'
}

# The actions a workflow file uses, normalised and sorted.
used() {
local file="$1"
{ refs "$file" S; refs "$file" J | grep -vE '/\.github/workflows/[^/@]+\.ya?ml@'; } \
| sed -E 's#^([^/@]+/[^/@]+)/[^@]*@#\1@#' \
| sort -u
}

# Fail closed: a `uses:` key at the start of a line (block `uses:` / `- uses:`,
# or a flow mapping opened on the line, `- {uses: …}`) whose value the matcher
# above cannot read is an error, not a silent skip. That covers folded or
# literal scalars (`uses: >-` with the ref on the next line), an empty value,
# and anything else that is not a local action (`./…`), a Docker image
# (`docker://…`), a reusable workflow (`owner/repo/.github/workflows/x.yml@ref`)
# or an action (`owner/repo[/path]@ref`). Write such a step as a plain scalar.
unreadable() {
local file="$1"
sed -E 's/[[:space:]]+#.*$//; s/[[:space:]]+$//' "$file" \
| grep -nE '^[[:space:]]*(-[[:space:]]+)?\{?[[:space:]]*["'\'']?uses["'\'']?[[:space:]]*:' \
| while IFS= read -r line; do
local n="${line%%:*}" v
v=$(printf '%s\n' "${line#*:}" \
| sed -E 's/^[[:space:]]*(-[[:space:]]+)?\{?[[:space:]]*["'\'']?uses["'\'']?[[:space:]]*:[[:space:]]*//; s/[[:space:]]*[,}].*$//; s/^["'\'']//; s/["'\'']$//')
Comment thread
hyperpolymath marked this conversation as resolved.
Resolved
if ! printf '%s\n' "$v" | grep -qE '^(\./|docker://|[A-Za-z0-9_.-]+/[A-Za-z0-9_./-]+@[A-Za-z0-9_./-]+$)'; then
printf '%s: %s\n' "$n" "${v:-<empty>}"
fi
done
}

# The actions the lock lists for workflow path $1, sorted.
locked() {
local path="$1"
awk -v wf="'$path':" '
/^workflows:/ { inwf = 1; next }
/^dependencies:/ { inwf = 0 }
inwf && $1 == wf { on = 1; next }
inwf && on && /^ - / { v = $2; gsub(/'\''/, "", v); print v; next }
inwf && on { on = 0 }
' "$lock" | sort -u
}

# Dependency keys present in the lock.
deps=$(awk '/^dependencies:/ { d = 1; next } d && /^ '\''/ { k = $1; gsub(/['\'':]/, "", k); print k }' "$lock")

checked=0
for wf in "$dir"/*.yml "$dir"/*.yaml; do
[[ -f "$wf" ]] || continue
rel=".github/workflows/$(basename "$wf")"
checked=$((checked + 1))
bad=$(unreadable "$wf")
[[ -z "$bad" ]] || err "$rel has uses: values this guard cannot read (write them as plain scalars): ${bad//$'\n'/; }"
u=$(used "$wf")
l=$(locked "$rel")
if ! grep -qF "'$rel':" "$lock"; then
[[ -z "$u" ]] || err "$rel uses actions but has no actions.lock entry: ${u//$'\n'/ }"
continue
fi
missing=$(comm -23 <(printf '%s\n' "$u" | sed '/^$/d') <(printf '%s\n' "$l" | sed '/^$/d'))
stale=$(comm -13 <(printf '%s\n' "$u" | sed '/^$/d') <(printf '%s\n' "$l" | sed '/^$/d'))
[[ -z "$missing" ]] || err "$rel uses actions the lock does not list (regenerate actions.lock): ${missing//$'\n'/ }"
[[ -z "$stale" ]] || err "$rel: actions.lock lists actions the workflow no longer uses: ${stale//$'\n'/ }"
for a in $l; do
Comment thread
hyperpolymath marked this conversation as resolved.
Resolved
printf '%s\n' "$deps" | grep -qxF "$a" || err "actions.lock has no dependencies entry for $a ($rel)"
done
done

# Transitive references: an action the lock records may itself use other
# actions (`uses:` under its dependency record, e.g. upload-pages-artifact ->
# upload-artifact@<sha>). Each of those must have its own record too.
while IFS= read -r t; do
[[ -n "$t" ]] || continue
printf '%s\n' "$deps" | grep -qxF "$t" || err "actions.lock: a dependency uses $t, which has no dependencies entry"
done < <(awk '/^dependencies:/ { d = 1; next } d && /^ uses:/ { u = 1; next } d && u && /^ - / { v = $2; gsub(/'\''/, "", v); print v; next } { u = 0 }' "$lock" | sort -u)

if [[ "$fail" -ne 0 ]]; then
echo "actions.lock check FAILED: a mismatched workflow does not start (startup_failure, zero jobs)."
exit 1
fi
echo "actions.lock check: OK ($checked workflows match the lock)"
Loading
Loading