Repository navigation
docs(spec): classify scenarios as draft requirements or library policy - #75
Merged
Merged
Conversation
Every scenario now sits in a Rule tagged @draft, with the draft section it implements, or @library for behaviour the draft leaves open. Cucumber inherits tags, so a scenario cannot hold a class of its own: the suite is grouped into Rules of one class each rather than tagged per scenario. Thirteen of the 49 scenarios trace to draft-07. The rest cover policy the page used to present under draft section headings, such as the 21 and 255 character limits, the comma rejection, the 409 for a same-body different-key request, and all response recording and replay.
Deploying website with
|
| Latest commit: |
233f612
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60ce4234.website-33l.pages.dev |
| Branch Preview URL: | https://spec-classification.website-33l.pages.dev |
mroderick
marked this pull request as ready for review
November 12, 2026 14:04
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Classifies every scenario in
docs/specs/idempotency.featureas a draft requirement or library policy, and says which on the published page.@draftRules name the draft section they implement: section 2.1 (1 scenario), 2.6 (5), 2.7 (7).@libraryRules hold the other 36 scenarios, grouped by theme.docs/specs/index.mdreplaces the eight overview bullets, which all read as draft-mandated, with a split list and the count on each side.13 of the 49 scenarios trace to draft-07. The other 36 cover policy this page used to present under draft headings: the 21 and 255 character limits, the comma rejection, the 409 for a same-body different-key request, and all response recording and replay, which the draft never mentions.
Review notes
The classification is the substance; scenario text is unchanged apart from position.
Worth a look: whether each library Rule reads as policy to you, and whether the section citations are the ones you want. Two were judgement calls. The concurrent 409 is cited to section 2.7, which states the status, although section 2.6 also mentions the conflict and the response body points there. The 422 for a reused key is cited to 2.7 for the same reason, while its body points at 2.2.
npm run format:checkandnpm run buildpass.