Repository navigation
fix: quieter tree-sitter notice, single readable errors, effective truncate mode (#21 B13/B17/B18) - #49
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Auto-diff warnings, cancellation output, and post-create write errors do not yet satisfy the stated diagnostic behavior.
4 open findings
What changed in this PR
Improves CLI diagnostics for tree-sitter fallbacks, truncation modes, and I/O errors.
Changes:
- Limits tree-sitter notices to relevant operations.
- Centralizes readable error reporting and adds output-path context.
- Adds end-to-end diagnostic regression tests.
| File | Description |
|---|---|
src/lib.rs |
Adjusts warnings, effective truncation mode, and path-aware errors. |
src/main.rs |
Centralizes CLI error formatting and exit codes. |
src/markdown.rs |
Adds path context to output creation failures. |
tests/test_diagnostics.rs |
Tests warnings, truncation notices, and errors. |
CHANGELOG.md |
Documents diagnostic improvements. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ancel message (review)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #21 (stacked on #44: retarget to master after #44 merges).
--signatures/--structureor--truncate smartwith--max-tokens; suggestscargo install context-builder --features tree-sitter-all.Error: <msg>(no DebugCustom{..}/Os{..}); output-path errors name the path. Exit code stays 1.mode: byte.tests/test_diagnostics.rs) run the binary; all 5 fail without the src changes (verified).