Repository navigation
fix: skip binary files with a Skipped entry; header names the directory, not its path (#21 P11) - #69
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Directory aliases and root paths are still labeled incorrectly, and plural binary summaries are grammatically malformed.
2 open findings
What changed in this PR
Updates report generation to omit detected binary files and avoid exposing absolute input paths.
Changes:
- Classifies binary content as skipped and reports binary counts.
- Uses directory display names in headers and token estimates.
- Adds integration coverage and changelog documentation.
| File | Description |
|---|---|
src/content_filter.rs |
Adds binary classification and reporting. |
src/markdown.rs |
Adds sanitized directory display names. |
src/lib.rs |
Uses display names in token estimates. |
tests/test_binary_and_header.rs |
Tests binary skipping and headers. |
tests/test_parallel_memory.rs |
Updates binary-handling expectations. |
CHANGELOG.md |
Documents the behavior change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Part of #21 (P11). content_filter::classify gains SkipReason::Binary (sniff via markdown::is_binary_content, same rule as the renderer); markdown::directory_display_name replaces the raw -d string in both headers and the --token-count estimate. Tests: tests/test_binary_and_header.rs (in-process classify + run_with_args + binary). One existing test (test_parallel_error_handling) expected the placeholder block; it now expects the Skipped entry.