Repository navigation
Conversation
… long (macOS build)
cListener::receiveSignal() takes intval_t (int64_t). On macOS int64_t is
'long long', so the overrides declared with 'long' in CoreControl, D2dBinder
and the D2dAmc mixin override nothing and clang rejects them ('non-virtual
member function marked override hides virtual member functions'); the D2dAmc
failure cascades into LteAmcD2D and NrAmcD2D. On Linux int64_t is 'long',
which is why CI does not see it. No behavior change.
This was referenced Nov 7, 2026
Member
|
Accepted into branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simu5G
dev(764db6f) does not build on macOS with OMNeT++ 6.5.0 and INET 4.7.0 (Apple clang):The same error occurs in
D2dBinder.hand in theD2dAmc.hmixin. TheD2dAmcfailure then cascades intoLteAmcD2DandNrAmcD2D(Define_ModuleandgetNrMcsTableForDirectionerrors).cListener::receiveSignal()takesintval_t, which isint64_t. On Linuxint64_tislong, so the overrides compile there and CI passes. On macOS it islong long, so alongparameter does not override the virtual function.This PR declares the parameter as
intval_tin the five places (CoreControl.h/.cc, D2dBinder.h/.cc, D2dAmc.h). It does not change behavior. With the change, release and debug build on macOS, andshowcases/nr/standalone(-c Standalone) runs to the end.