Skip to content

Flatten scorecard notes to a plain array (correction to #673) - #676

Merged
s-harding merged 1 commit into
mainfrom
s-harding/qa-scorecard-notes-plain-array
Sep 23, 2026
Merged

s-harding merged 1 commit into
mainfrom
s-harding/qa-scorecard-notes-plain-array

Conversation

@s-harding

@s-harding s-harding commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Why

#673 merged a few hours ago and documented notes, reviewer and review_status on the Preview conversation_scorecard. It modelled notes as a note.list wrapper object. The API is changing that shape: notes becomes a plain array, matching its sibling field evaluators on the same scorecard entry. The spec still describes the wrapper, so SDKs and the Postman collection would generate the wrong type.

This corrects #673 rather than building on it.

What

  • Flattens conversation_scorecard.notes to an array of note objects.
  • Drops the per-item type discriminator from conversation_scorecard_note.
  • Deletes the now-unused conversation_scorecard_notes wrapper schema.
  • Updates the three inline response examples to the flattened shape.

reviewer and review_status are unchanged. Preview only — no stable version is touched.

Validation

fern isn't installed locally and the repo's CLAUDE.md says not to install it globally, so fern check wasn't run. Validated manually instead:

  • The file parses as YAML.
  • A script walked every local $ref in descriptions/0/api.intercom.io.yaml — 395 distinct targets — and confirmed each resolves to an existing schema, and that none point at the deleted conversation_scorecard_notes.

🤖 Generated with Claude Code

Intercom-OpenAPI#673 documented notes on the Preview conversation_scorecard
using a note.list wrapper. intercom/intercom#580869 removes that wrapper
server-side, so notes is now a plain array like its sibling evaluators.
Corrects the schema, the conversation_scorecard_note type discriminator,
and the three inline response examples to match.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@s-harding
s-harding merged commit f0fae11 into main Sep 23, 2026
3 checks passed
@s-harding
s-harding deleted the s-harding/qa-scorecard-notes-plain-array branch September 23, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants