Repository navigation
Vendor TypeScript fork 608a9db for abstract and accessor members - #25
Draft
inth3shadows wants to merge 1 commit into
Draft
inth3shadows wants to merge 1 commit into
inth3shadows wants to merge 1 commit into
Conversation
inth3shadows
marked this pull request as draft
November 8, 2026 02:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by a grammar regression confirmed by both native reviewers. Importing fork
608a9dbmakes generic calls and typed tags usingtypeof abstractsilently become comparison expressions in both TypeScript and TSX. Native and wasm extraction both omit the call reference despite reporting no parse errors.type T = (typeof abstract)also newly errors. A complete valid example passes strict tsc:The regression comes from adding
abstractglobally to_reserved_identifier(public patch line 311); it is separate from the known bareabstracttype-name limitation. Fix it in the grammar fork, add tree-shape/extraction regressions, then update this pin and run a fresh verify round before merge.This change otherwise updates native C and wasm TypeScript/TSX grammars from fork
7dbdfaeto608a9dbfor members namedabstract/accessorand auto-accessor modifiers. It refreshes provenance/hash tables, the public reproducer patch and baseline; mirrors fork fixtures, promotes the static-accessor gap, and pins member/newline/type-argument shapes plus native extraction without deferral.Validation passes: rebuilt kernel, normal build, 73 focused grammar/parity/scaffold tests (19 languages), full suite 11,122 passed / 2 expected failures / 61 skipped, public patch roundtrip, strict local fixtures, and differential CI. Full differential: 14,608 files, 0 new / 0 worse. Two existing Effect divergences and four unrelated local gaps remain. These checks do not detect the silent regression above.
Draft pending grammar correction; no merge or deployment.