Repository navigation
Switch Python packaging to scikit-build-core - #298
Merged
Merged
Conversation
- Replace setup.py and MANIFEST.in with [tool.scikit-build] config - Install only the module, so wheels no longer ship src/ipc sources - Keep IPCTK_WITH_SIMD and CMAKE_ARGS working Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pybind11 3 and scikit-build-core both require Python 3.8 or newer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the hand-written
setup.py(setuptools plus a custom CMakebuild_ext) with scikit-build-core, touching only the Python packaging, its docs, and the CI path filters.[tool.scikit-build]inpyproject.tomldrives CMake: a Release build of only theipctktarget, in a persistentbuild/<wheel tag>/folder.python/CMakeLists.txtinstalls the module into apythoncomponent underif(SKBUILD), and the wheel holds only that component.setup.pyandMANIFEST.inare removed. The sdist is the git-tracked files minus.github/,docs/(exceptPYPI_README.md),notebooks/, andtests/.Impacts:
main, setuptools' package discovery treatssrc/as a src-layout and ships 291 C++ sources as a top-levelipc/package in site-packages.pip install .takes 30 s instead of 111 s.Build options
IPCTK_WITH_SIMDandCMAKE_ARGSwork as before, so the CI workflows only change their path filters.pip install . -C cmake.define.<NAME>=<VALUE>.Breaking changes
DEBUG=1 pip install .no longer builds in Debug; useSKBUILD_CMAKE_BUILD_TYPE=Debug(or-C cmake.build-type=Debug).IPCTK_WITH_SIMD=now disables SIMD, since CMake treats an empty value as false. Before, it kept SIMD on.python setup.py ...commands are gone; usepip install .orpython -m build.Type of change
How Has This Been Tested?
nose2inpython/tests: 107 tests pass.mainwithsetup.py.IPCTK_WITH_SIMD=0 pip install .givesIPC_TOOLKIT_WITH_SIMD:BOOL=0in the CMake cache.pypi.yml, which runs on this PR.Test Configuration:
Checklist