Repository navigation
Fix stale ccache keys and slow Debug CI tests - #301
Merged
Merged
Conversation
- Key ccache by run ID and restore by prefix; save only on main - Drop /Zi from Windows Debug so ccache can cache it - Build Windows Python with Ninja so ccache runs - Build Linux/macOS Debug at -O1 to keep asserts but inline Eigen - Loosen the CCD tolerance in the thickness test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 229 229
Lines 23047 23047
Branches 1619 1618 -1
=======================================
Hits 22324 22324
Misses 723 723
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the CI caching and Debug test setup across the
Build,Python,Coverage,CUDA, andDocsworkflows, plus one pathological unit test. On #300, CI took ~40 min wall-clock, and Linux Debug failed on a timeout.Linux-Debug-cache,coverage-cache, …). Cache entries are immutable, so each was saved once on 2026-10-12 and never updated. Every build job on Fix Eigen ABI pin when a parent project shadows the Eigen recipe #300 got 0/465 hits, while the ODR job, which keys byrun_id, got 459/465 on the same commit./Ziwrites to a shared PDB that ccache can't cache (465/465 uncacheable). Windows Python used the Visual Studio generator, which ignoresCMAKE_CXX_COMPILER_LAUNCHERand compiles each target's files serially (2,340 s build vs 616 s on Linux).-O0, the Debug test step took 1,079–1,713 s vs 131–166 s in Release.CCD stops at the thicknessalone took 1,319 s on macOS and timed out at 1,500 s on Linux, also failingmainin run 42642942563.Impact:
mainccache instead of compiling from scratch.CI changes
actions/cache/restoreusing key<prefix>-ccache-${{ github.run_id }}andrestore-keys: <prefix>-ccache-, the same pattern asodr-check.yml.actions/cache/saveonly on pushes tomain(always fordocs.yml, which only runs on push), so PR caches don't evictmain's under the 10 GB limit./Od /Ob0 /RTC1, matching whatcuda.ymlalready does.CMAKE_GENERATOR=Ninja.-O1instead of-O0;NDEBUGstays undefined, so asserts are still checked.Test change
CCD stops at the thicknessuses aTightInclusionCCDwith a1e-3tolerance instead of the default1e-6.SKIP, since the test is now cheap everywhere.CCD stops at the thickness, Release (5 broad phases)-O1, 456 tests*-cacheentries no longer match any key and will expire after 7 days unused.mainafter merge.Type of change
How Has This Been Tested?
ipc_toolkit_tests "[thickness]"in Release: all 9 test cases pass (6,347 assertions).ctest -j 8on a Debug build configured with-DCMAKE_CXX_FLAGS_DEBUG=-O1: 456/456 pass, 12.8 s.ctest -j 8in Release: 457/457 pass, 43.4 s.main.Test Configuration:
Checklist