Repository navigation
Fix collision filter on codimensional broad-phase passes - #303
Merged
Merged
Conversation
- Translate subset-local ids to mesh vertex ids before filtering - Restore the mesh filter on the broad phase after each pass Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 96.86% 96.87%
=======================================
Files 229 229
Lines 23047 23075 +28
Branches 1619 1619
=======================================
+ Hits 22325 22353 +28
Misses 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
Candidates::build(static and CCD overloads) applyingmesh.can_collideto the wrong vertices in the codimensional broad-phase passes.can_collidewas called on them as if they were mesh vertex ids.can_collidefilter, pairs that should be filtered leaked through and allowed pairs were dropped.Fix
broad_phase->can_vertices_collide = mesh.can_collideafter each pass, since the temporary filters capture locals.Impact
Type of change
How Has This Been Tested?
[candidates][codim][filter]): 52 assertions. It fails 12 of them onmainand passes with this change.ipc_toolkit_tests "[candidates],[codim] ~[!benchmark]": all pass (3951 assertions in 19 test cases).Test Configuration:
testpreset)Checklist