Repository navigation
fix modded key bindings never being registered on neoforge - #1005
Open
Nahida1212 wants to merge 1 commit into
Open
Nahida1212 wants to merge 1 commit into
Nahida1212 wants to merge 1 commit into
Conversation
isXander
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On NeoForge, Controlify never converts modded key mappings into controller
bindings, even though the Bindings API docs
state that "otherwise unhandled modded
KeyMappings" are automaticallyconverted on both Fabric and NeoForge.
Symptoms on NeoForge (tested with Controlify 3.5.3+mc26.1 on MC 26.1.2):
never a category belonging to another mod.
bindings (the ones that use a book as their fallback icon).
Failed to automatically register modded keybindline is logged either,because
ControlifyBindings#registerModdedBindingsiterates over an emptycollection.
Reported in / related to: #541, #572, #949