Repository navigation
bugfix/423_uniform-tag-parsing - #629
Open
redcatbear wants to merge 4 commits into
Open
redcatbear wants to merge 4 commits into
redcatbear wants to merge 4 commits into
Conversation
|
kaklakariada
requested changes
Oct 10, 2026
Comment on lines
+307
to
+310
| if (TAG_PATTERN.matcher(trimmed).matches()) | ||
| { | ||
| this.listener.addTag(trimmed); | ||
| } |
Contributor
There was a problem hiding this comment.
This silently ignores invalid tags. Should we at least log a warning to avoid surprises?
| public static final String ARTIFACT_TYPE = "[a-zA-Z]+"; | ||
| public static final String BULLETS = "[+*-]"; | ||
| // [impl->dsn~md.tags-format~1] | ||
| public static final String TAG_PATTERN = "[a-zA-Z0-9][a-zA-Z0-9_]*"; |
Contributor
There was a problem hiding this comment.
Consistency: tag pattern was defined as \\p{Alnum}\\w* before. Use a common constant if possible.
| public static final String ARTIFACT_TYPE = "[a-zA-Z]+"; | ||
| public static final String BULLETS = "[+*-]"; | ||
| // [impl->dsn~md.tags-format~1] | ||
| public static final String TAG_PATTERN = "[a-zA-Z0-9][a-zA-Z0-9_]*"; |
kaklakariada
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #423.