Repository navigation
Conversation
Archive Compute for visionOS and the visionOS Simulator and include both in Compute.xcframework. Use canImport(Darwin) for the attribute vtable and type description branches in Swift. The C headers select these declarations with TARGET_OS_MAC, so visionOS must use the Darwin branch as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release XCFramework only contains macOS, iOS, and iOS Simulator slices, so projects that depend on the Compute binary cannot build for visionOS. The Xcode project already supports
xrosandxrsimulator.Archive Compute for visionOS and the visionOS Simulator in
Scripts/create-xcframework.sh, and include both archives inCompute.xcframework.The C headers select the attribute vtable and type description declarations with
TARGET_OS_MAC, which is true on every Apple platform. The Swift code usedos(iOS) || os(macOS)for the same branches, so a visionOS build used the non-Darwin branch and failed to compile. UsecanImport(Darwin), asGraph.swiftalready does. The behavior on macOS and iOS does not change.Validation