Repository navigation
Move the Santa sync server to the stable v1 protos - #1185
Merged
Merged
Conversation
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Santa sync server to the stable v1 protos
Closes #1184
Problem
osctrl's Santa sync server was built on
syncv2frombuf.build/gen/go/northpolesec/protos. North Pole Security has said that v2 is their internal protocol, "not supported for external users", and that they are removing it from the published protos (northpolesec/santa#1270). After that, the next update of the protos dependency will break osctrl's build. v1 is the stable protocol for third-party sync servers. North Pole Security will list osctrl as a sync server in the Santa docs once it uses v1.Change
pkg/santa/sync.goandcmd/tls/handlers/santa.go, plus their tests, switch the import from.../protocolbuffers/go/syncv2to.../protocolbuffers/go/sync(packagesyncv1).pkg/santa/README.md: the endpoint now says it serves Santa sync protocol v1.No behaviour changes for Santa clients. They already talk v1 to osctrl, and osctrl used no v2-only fields.
go.modis unchanged because v1 and v2 come from the same module.Compatibility
SyncType,ClientMode,Policy,RuleType,Decision), so existing rules, modes and pending sync types need no migration.SEATBELTpolicy was never offered in the UI and is now rejected by the API. The CEL-fallback decisions (ALLOW_CEL_FALLBACK,BLOCK_CEL_FALLBACK) are not sent by v1 clients.Security / operational impact
None. Auth (
X-Osctrl-Santa-Token), body limits, UUID validation and node/environment ownership checks are untouched.Validation
go build ./...go vet ./pkg/santa ./cmd/tls/...go test ./pkg/santa/... ./cmd/tls/...passgrep -r syncv2 pkg cmdis emptyFollow-up
After release, reply on northpolesec/santa#1270 so osctrl can be listed as a sync server.